1681242 - Remove obsolete CGEvent logging workaround added for Mac OS X 10.10.2

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, task, P3)

Description

[Chris Peterson [:cpeterson]]

This workaround (added for Mac OS X 10.10.2 in bug 1092855) is no longer needed because Firefox 79+ requires macOS 10.12 or greater.

Comment 1

[Chris Peterson [:cpeterson]]

I stumbled upon this obsolete workaround when investigating bug 1680516. I was auditing the callers of nsCocoaFeatures::macOSVersionMajor() and nsCocoaFeatures::macOSVersionMinor() to make sure other callers didn't need to worry about macOS 11.0 Big Sur being reported as version 10.16 or 11.0 depending on the SDK Firefox was built with.

I did find one other caller in XPCOM manifest version checking code. It probably warrants more careful audit by someone who knows XPCOM.

https://searchfox.org/mozilla-central/rev/1843375acbbca68127713e402be222350ac99301/xpcom/components/ManifestParser.cpp#465-468

Comment 2

[Chris Peterson [:cpeterson]]

Attachment: Bug 1681242 - Remove obsolete CGEvent workaround needed for macOS versions < 10.10.2. r?haik

This workaround is no longer needed because Firefox 79+ requires macOS 10.12 or greater.

Comment 3

[Chris Peterson [:cpeterson]]

Try build just to make sure I didn't break non-macOS builds:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=eb7ccafa65c2a27b9b17b3b8165ba8f4d08c325e

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/73f050da7d20
Remove obsolete CGEvent workaround needed for macOS versions < 10.10.2. r=haik,spohl

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/73f050da7d20