1681292 - The Submenus from a Tab's Context menu are not indicated by VoiceOver

Status: VERIFIED FIXED

(Core :: Disability Access APIs, defect, P1)

Description

[Rares Doghi, Desktop QA]

Attachment: Submenu.mp4

[Affected versions]
85.0a1 (2020-12-08)

[Affected platforms]
MacOsX

[Preconditions]
Have VoiceOver enabled on MacOS (Command + F5)

[Steps to reproduce]

1. Open the Firefox browser and reach a tab's Context Menu (CTRL+Option+Shift+M)
2. Reach the Close multiple Tabs submenu.
3. Reach any of the Options (Close Other tabs / Close Tabs to the Right)

[Expected result]
The User should be able to reach the Close Multiple tabs submenu.

[Actual result]
The Submenus from the tab's Context menu are not indicated by VoiceOver.

Comment 1

[Rares Doghi, Desktop QA]

I think the severity for this issue should be an S3.

Comment 2

[Marco Zehe (:MarcoZ)]

To be clear: The menu item's label is spoken, but the fact that it is a sub menu, and you can press RightArrow or Enter to open it, is not. This is indicated perfectly fine on Windows, so is a VoiceOver-specific bug.

Comment 3

[Marco Zehe (:MarcoZ)]

This should be fixed before final customer release if possible. This will also still be a bug with the Proton redesign, as not all menus will switch to native menus with that redesign.

Comment 4

[Morgan Reschenberg [:morgan]]

Huh I just tried this, and for me VoiceOver says "submenu, 2 items" when I reach the "Close all tabs" sub menu. It also correctly indicates submenu-ness for the other ones in this context menu, along with their length.
:marcoz, could you test this in today's nightly to see if this is still an issue?

Comment 5

[Marco Zehe (:MarcoZ)]

Yes, this is still an issue for me when pressing VO+Shift+M on a tab and down arrowing through the top level menu items. None of them are announced as sub menu, like Close Other Tabs, or the Send To Device sub menu. On the normal menu bar, like the History menu, items such as the Recently Closed Tabs, are announced as sub menus.

Comment 6

[Morgan Reschenberg [:morgan]]

Attachment: Bug 1681292: Ensure menu items correctly expose AXVisibleChildren and AXChildren r?eeejay

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e482e3589b3c
Ensure menu items correctly expose AXVisibleChildren and AXChildren r=eeejay

Comment 8

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/e482e3589b3c

Comment 9

[Rares Doghi, Desktop QA]

Hi, a few things here, as I was trying to Verify this fix I came across an issue where the submenus would open automatically, without me selecting the option and it was really hard for me to navigate through to the second option, for instance going down to the Close tab option I would remain stuck at the Open in container sub menu, every time I would try to move down to the next option it would just go inside the sub menu.

Should I log a different issue for it ? Once I do get inside the sub menu all the items can be clicked correctly and they are also read out loud without issue which does make this issue Verified as fixed.

Should we open a new bug for the other issues or will they be resolved with this one ?

Other issues being :

1. That navigation is broken when inside a menu with multiple submenus as they are automatically opened and navigated to.
2. After selecting one of the sub menu items with VO+Space > Voice over will remain inside that sub menu even if the focues is changed to a new tab and the user cannot exit that focused item.

Comment 10

[Morgan Reschenberg [:morgan]]

(In reply to Rares Doghi from comment #9)

Hi, a few things here, as I was trying to Verify this fix I came across an issue where the submenus would open automatically, without me selecting the option and it was really hard for me to navigate through to the second option, for instance going down to the Close tab option I would remain stuck at the Open in container sub menu, every time I would try to move down to the next option it would just go inside the sub menu.

This isn't new to this bug; context submenus auto open when you focus on their parent menu item. As far as exiting a submenu, I've been using VO+Shift+up to leave the sub menu group and go back to the regular menu. I can navigate from there just fine.

Should I log a different issue for it ? Once I do get inside the sub menu all the items can be clicked correctly and they are also read out loud without issue which does make this issue Verified as fixed.

I don't know if the above is an actual issue, I think its expected.

Should we open a new bug for the other issues or will they be resolved with this one ?

Other issues being :

1. That navigation is broken when inside a menu with multiple submenus as they are automatically opened and navigated to.

Yeah you can file something for this

2. After selecting one of the sub menu items with VO+Space > Voice over will remain inside that sub menu even if the focues is changed to a new tab and the user cannot exit that focused item.

Ah yeah this is a focus loss issue, I'll file something here, I don't think its unique to submenus. I've seen this happen other places with doorhangers.

Comment 11

[Rares Doghi, Desktop QA]

I've added the issue here : Bug 1685993

@Morgan Please let us know if any issue was logged for the Lost Focus issue.

Comment 12

[Rares Doghi, Desktop QA]

This issue is verified as fixed in our latest Nightly build 86.0a1 (2021-01-10).

Comment 13

[Morgan Reschenberg [:morgan]]

Do you have STR for this issue you posted above?

That navigation is broken when inside a menu with multiple submenus as they are automatically opened and navigated to.

Comment 14

[Morgan Reschenberg [:morgan]]

oops comment collision nevermind !

Comment 15

[Rares Doghi, Desktop QA]

Since the Other versions are marked with wontfix , I will update the Status flag to Verified.