1681295 - min/max/close button is too small in KDE with HiDPI

Status: RESOLVED DUPLICATE of bug 1813697

(Core :: Widget: Gtk, defect, P3)

Description

[Guo Yunhe]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:83.0) Gecko/20100101 Firefox/83.0

Steps to reproduce:

1. In Linux with KDE, set screen scale to 1.5.
2. Hide titlebar of Firefox.
3. Compare the size of min/max/close button with other application windows.

Actual results:

Firefox uses small size min/max/close buttons.

Expected results:

Firefox should use same size min/max/close buttons as other applications.

Comment 1

[Negritas Sergiu, Desktop QA]

Hello I have tried to reproduce the issue with the description provided on Ubuntu 20 with firefox Nightly 85.0a1(2020-12-14).
Could you please answer the following questions in order to investigate it further?

1. Does this issue happen with a new profile? Here is a link on how to create a new profile: https://support.mozilla.org/en-US/kb/profile-manager-create-remove-switch-firefox-profiles
2. Are you using add-ons? If so could you please list them?
3. Does this issue occur in the latest nightly version of firefox? Here is a link from where you can download it: https://www.mozilla.org/en-US/firefox/channel/desktop/

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 3

[Guo Yunhe]

I can reproduce this with Firefox 86.0a1 (nightly 20210117). Please note it only happens in KDE with 1.5 scale factor. Ubuntu is not the correct environment to reproduce it. You can try KUbuntu.

Comment 4

[Martin Stránský [:stransky] (ni? me)]

What do you mean 1.5 scale factor ? Is that font scale? AFAK Gtk supports only integer scales (1,2,3...) this this must be either font scale or some KDE specific screen scale similar to GNOME fractional scale (https://www.linuxuprising.com/2019/04/how-to-enable-hidpi-fractional-scaling.html).

Comment 5

[Dmitry Petrov]

Attachment: Firefox buttons (above) and buttons of KDE app. Display scale - 125%

Comment 6

[Dmitry Petrov]

Attachment: Firefox buttons (above) and buttons of KDE app. Display scale - 150%

Comment 7

[Dmitry Petrov]

Attachment: Firefox buttons (above) and buttons of KDE app. Display scale - 175%

Comment 8

[Dmitry Petrov]

To reproduce this bug, set the Display Scale to 125%, 150% or 175% in Plasma Display Settings, restart session and open browser.

Comment 9

[Dmitry Petrov]

Tested in KDE Plasma 5.21.5 with Firefox Nightly 91.0a1

Comment 10

[asgatoril]

Can confirm this
Firefox 91.0.2
KDE Plasma 5.22.4

Comment 11

[Firefox User]

I can also confirm this
Firefox 95.0.2
KDE 5.23.4

Has there been any update on this?

Comment 12

[Emilio Cobos Álvarez (:emilio)]

This is only an issue with fractional scale right? Setting the scale to 200% works alright.

Comment 13

[Emilio Cobos Álvarez (:emilio)]

Yeah, so taking a closer look the "issue" is here. In particular:

• rootWidget->GetDefaultScale().scale is 1.5, but...
• LookAndFeel::GetFloat(LookAndFeel::FloatID::TextScaleFactor) is 1.5 as well

So we end up with a scale factor of 1.

Firefox's behavior matches that of other GTK apps like gedit... We could apply the 1.5 scale, though it'd be inconsistent with every other GTK app (and it'd also break / change behavior of the text scale factor on GNOME, presumably).

Comment 14

[Dmitry Petrov]

Attachment: Firefox 96 buttons (above) and buttons of KDE app. Display scale - 125%

Firefox 96 changes icons style, and now they look normally on scaled screens.

Comment 15

[Dmitry Petrov]

Attachment: Firefox 96 buttons (above) and buttons of KDE app. Display scale - 150%

Comment 16

[Emilio Cobos Álvarez (:emilio)]

(In reply to Dmitry Petrov from comment #14)

Created attachment 9259220 [details]
Firefox 96 buttons (above) and buttons of KDE app. Display scale - 125%

Firefox 96 changes icons style, and now they look normally on scaled screens.

We only changed it for themes. If you use the system theme native buttons are still shown.

Comment 17

[Dmitry Petrov]

Comment on attachment 9225239 [details]
Firefox buttons (above) and buttons of KDE app. Display scale - 125%

(In reply to Emilio Cobos Álvarez (:emilio) from comment #16)

(In reply to Dmitry Petrov from comment #14)

Created attachment 9259220 [details]
Firefox 96 buttons (above) and buttons of KDE app. Display scale - 125%

Firefox 96 changes icons style, and now they look normally on scaled screens.

We only changed it for themes. If you use the system theme native buttons are still shown.

Yes, problem still there.

Comment 18

[Freaked Enough]

Attachment: ffx96

this issue is still present and more than annoying if you want to make use of your touch screen.

Comment 19

[Ashkan Laei]

Attachment: Firefox Developer Edition 102.0b3 (64-bit) and System Settings in custom scale 80%

I have reduced my scale factor to 80% (with xrandr command) and now, Firefox buttons are bigger than other windows. I think it's the same bug.

Comment 20

[Mark Duncan]

Attachment: Screenshot_20230220_090808.png

This is still an issue in Firefox 109 and KDE Plasma 5.27.

Comment 21

[Emilio Cobos Álvarez (:emilio)]

We fixed this in bug 1813697. Nightly should behave appropriately :)