1681382 - Simplify calls into BrowserSearchTelemetry

Status: RESOLVED FIXED

(Firefox :: Search, task, P2)

Description

[Mark Banner (:standard8)]

As part of the general search telemetry cleanup, I want to simplify some of the calls into the new BrowserSearchTelemetry (created in bug 1680735):

• There is a recordSearchSelectedResultMethod and a recordUrlbarSelectedResultMethod, both of these forward into the same internal function. We can simply pass a parameter instead and save the complexity.
• recordSearch is only called from BrowserSearch (in browser.js), the two functions there are basically forwarders. We should just call directly to BrowserSearchTelemetry.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1681382 - Merge BrowserSearchTelemetry.record{Search|Urlbar}SelectedResultMethod functions into one. r?daleharvey!

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1681382 - Drop BrowserSearch.record*SearchInTelemetry and call BrowserSearchTelemetry direct. r?daleharvey!

Depends on D99206

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a9df61e2ab85
Merge BrowserSearchTelemetry.record{Search|Urlbar}SelectedResultMethod functions into one. r=daleharvey
https://hg.mozilla.org/integration/autoland/rev/66a4a0e2a9b1
Drop BrowserSearch.record*SearchInTelemetry and call BrowserSearchTelemetry direct. r=daleharvey

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/a9df61e2ab85
https://hg.mozilla.org/mozilla-central/rev/66a4a0e2a9b1