Closed Bug 1681415 Opened 5 years ago Closed 5 years ago

blame not working for all of StaticPrefList.yaml

Categories

(Webtools :: Searchfox, task)

task

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 1593367

People

(Reporter: mccr8, Unassigned)

Details

I noticed that the blame hover is not working correctly for at least some parts of StaticPrefList.yaml.

https://searchfox.org/mozilla-central/rev/71621bfa47a371f2b1ccfd33c704913124afb933/modules/libpref/init/StaticPrefList.yaml#4723

For instance, it does work for the blocks next to gl.allow-high-power, but not for gfx.webrender.software or some of the prefs near it.

What does "not working correctly" mean? I saw

Bug 1673715 - Make gfx.webrender.software a static pref. r=lsalzman
Jeff Muizelaar <jmuizelaar@mozilla.com>, Tue, 27 Oct 2020 20:34:59 +0000
Show annotated diff or full diff
Show latest version without this line
Show earliest version with this line

for gfx.webrender.software. Is this incorrect?

It's working for me at the current moment. I think you likely experienced the problem where the rust webserver serves both blame lookups (fast) and fetching specific revisions of source (potentially insanely slow), and the latter can bottleneck the former. Because the nginx reverse proxy can cache blame lookups, it's possible for it to seem like some blame lookups are successfully being answered by the server when instead they were just previously looked up and already cached by nginx.

I'm duping this to bug 1593367 where I've described the problem in more detail. I think we also may have discussed this on chat.mozilla.org recently-ish, but I don't know that any decision was reached beyond "yes, we should make it so blame doesn't get blocked".

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → DUPLICATE

Yeah, it just wasn't showing anything when I hovered over the side bar.

Thanks for looking!

You need to log in before you can comment on or make changes to this bug.