Re-enable MeasureInitializeTime test
Categories
(Data Platform and Tools :: Glean: SDK, defect, P1)
Tracking
(Not tracked)
People
(Reporter: janerik, Assigned: chutten)
References
(Regression)
Details
(Whiteboard: [telemetry:fog:m?])
Attachments
(1 file)
With the timespan implemented on top of RLB we should re-enable the MeasureInitializeTime test here: https://searchfox.org/mozilla-central/rev/71621bfa47a371f2b1ccfd33c704913124afb933/toolkit/components/glean/gtest/TestFog.cpp#39-42
However we can't because in the test just before we flip upload enabled back and forth, resulting in the deletion of stored data, including the initialization timespan.
We can't just move the test in between either, because the flip-flop is intended to run while Glean is initializing, but checking a metric would block on initialize to finish.
I don't think there is a way to keep both things right now.
|
Assignee | |
Comment 1•3 years ago
|
||
With the RLB in place, I don't think testing the setting of upload enabled and disabled during init is coverage that's important for FOG, so we can remove the problematic parts of test FogInitDoesntCrash and proceed.
|
|
Assignee | |
Comment 2•3 years ago
|
||
Remove the flipping of the data pref during FOG init test because, with the
dispatcher now a part of the RLB, this isn't something we should test at this
level.
Pushed by chutten@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/eb309cb4fb0c Re-enabled MeasureInitializeTime test r=janerik
|
||
Comment 4•3 years ago
|
||
| bugherder | ||
Description
•