1681682 - Crash in [@ mozilla::dom::GamepadPlatformService::GetParentService]

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Both crashes with macOS (2 different devices).

Crash report: https://crash-stats.mozilla.org/report/index/87789e4e-0708-4400-847e-ab5670201207

MOZ_CRASH Reason: MOZ_RELEASE_ASSERT(gGamepadPlatformServiceSingleton) (Impossible for monitor thread to be running with no platform service)

Top 10 frames of crashing thread:

0 XUL mozilla::dom::GamepadPlatformService::GetParentService dom/gamepad/GamepadPlatformService.cpp:106
1 XUL  dom/gamepad/cocoa/CocoaGamepad.cpp:433
2 XUL  dom/gamepad/cocoa/CocoaGamepad.cpp:433
3 IOKit __IOHIDDeviceInputElementValueCallback 
4 CoreFoundation __CFDictionaryApplyFunction_block_invoke 
5 CoreFoundation CFBasicHashApply 
6 CoreFoundation CFDictionaryApplyFunction 
7 IOKit __IOHIDQueueValueAvailableCallback 
8 IOHIDLib IOHIDIUnknown::genericRelease 
9 CoreFoundation __CFMachPortPerform 

Comment 1

[Chris Martin [:cmartin]]

Hi Sebastian,

I will look into this immediately, and hopefully be able to get it resolved before the merge date. If it seems that I won't be able to fix it in time, I will NI a code sheriff for a backout.

Does that sound like an alright plan?

Comment 2

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

You can judge it best when it might be fixed. E.g. early in the beta cycle should be good enough. Bug 1681750 is the more frequent one.

Comment 3

[Chris Martin [:cmartin]]

Attachment: Bug 1681682 - Fix Mac OS X crash in GamepadPlatformService::GetParentService

Bug 1657404 added assertions to catch errors in the platform-specific backends
for Gamepad. A bug in CocoaGamepad.cpp:StopGamepadMonitoring() causes one of
the new assertions to fire off.

As the solution to this is not easy, and a fix is required for Beta, the
easiest fix for now is to disable the assertion. In the long run, this needs
to be fixed.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/25b7e43abcd4
Fix Mac OS X crash in GamepadPlatformService::GetParentService r=haik

Comment 5

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/25b7e43abcd4

Comment 6

[Julien Cristau [:jcristau]]

Should be fixed in beta by backout:
https://hg.mozilla.org/releases/mozilla-beta/rev/0f0e8d040ea71e2ab86e80215fc0e9a7275d1e2a