1681738 - Intermittent GeckoProfiler.GetProfile | Expected equality of these values:

Status: RESOLVED FIXED

(Core :: Gecko Profiler, defect, P2)

Description

[Treeherder Bug Filer]

Filed by: archaeopteryx [at] coole-files.de
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=324144291&repo=try
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/IxyWj04cQKymxqCgCwYa3Q/runs/0/artifacts/public/logs/live_backing.log

---

[task 2020-12-10T12:17:03.933Z] 12:17:03     INFO -  TEST-START | GeckoProfiler.GetProfile
[task 2020-12-10T12:17:03.950Z] 12:17:03  WARNING -  TEST-UNEXPECTED-FAIL | GeckoProfiler.GetProfile | Expected equality of these values:
[task 2020-12-10T12:17:03.951Z] 12:17:03     INFO -    features.size()
[task 2020-12-10T12:17:03.951Z] 12:17:03     INFO -      Which is: 1
[task 2020-12-10T12:17:03.951Z] 12:17:03     INFO -    2u
[task 2020-12-10T12:17:03.951Z] 12:17:03     INFO -      Which is: 2 @ /builds/worker/checkouts/gecko/tools/profiler/tests/gtest/GeckoProfiler.cpp:1820
[task 2020-12-10T12:17:03.951Z] 12:17:03  WARNING -  TEST-UNEXPECTED-FAIL | GeckoProfiler.GetProfile | Value of: found
[task 2020-12-10T12:17:03.951Z] 12:17:03     INFO -    Actual: false
[task 2020-12-10T12:17:03.951Z] 12:17:03     INFO -  Expected: true
[task 2020-12-10T12:17:03.951Z] 12:17:03     INFO -  features doesn't contain "stackwalk" @ /builds/worker/checkouts/gecko/tools/profiler/tests/gtest/GeckoProfiler.cpp:1821
[task 2020-12-10T12:17:03.951Z] 12:17:03  WARNING -  TEST-UNEXPECTED-FAIL | GeckoProfiler.GetProfile | test completed (time: 15ms)

Comment 1

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

The new tests from bug 1680995 assume that stack-walking is always available, but some platforms may not support it.

So the tests should check if the profiler supports a feature (e.g., with profiler_get_available_features) before looking for that feature in the output.

Comment 2

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Oh, that was beta on macos, this explains why it was not visible before: Stack-walking is only enabled on Nightly/Mac because IIRC it requires frame pointers, which help with debugging, but add some overhead, that's why they're not present in beta&release.

Comment 3

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: Bug 1681738 - GeckoProfiler.GetProfile gtest: Only check JSON for features that are actually active - r?canaltinova

On some platforms, features may be unavailable. E.g.: StackWalk on Mac non-Nightly.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/acba856d14fd
GeckoProfiler.GetProfile gtest: Only check JSON for features that are actually active - r=canaltinova

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1680995

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/acba856d14fd

Comment 7

[Intermittent Failures Robot]

3 failures in 4060 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 3

Platform breakdown:

• macosx1014-64-shippable-qr: 3

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1681738&startday=2020-12-07&endday=2020-12-13&tree=all