1681756 - Crash in [@ mozilla::wr::DCSurface::GetTile]

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Sean Feng [:sefeng]]

Crash report: https://crash-stats.mozilla.org/report/index/36f2e46e-3d27-467b-8095-9201a0201209

MOZ_CRASH Reason: MOZ_RELEASE_ASSERT(tile_it != mDCTiles.end())

Top 10 frames of crashing thread:

0 xul.dll mozilla::wr::DCSurface::GetTile const gfx/webrender_bindings/DCLayerTree.cpp:651
1 xul.dll mozilla::wr::DCLayerTree::Bind gfx/webrender_bindings/DCLayerTree.cpp:312
2 xul.dll mozilla::wr::RenderCompositorANGLE::Bind gfx/webrender_bindings/RenderCompositorANGLE.cpp:856
3 xul.dll mozilla::wr::wr_compositor_bind gfx/webrender_bindings/RenderCompositor.cpp:52
4 xul.dll webrender_bindings::bindings::{{impl}}::bind gfx/webrender_bindings/src/bindings.rs:1311
5 xul.dll webrender::renderer::Renderer::render_impl gfx/wr/webrender/src/renderer.rs:3523
6 xul.dll webrender::renderer::Renderer::render gfx/wr/webrender/src/renderer.rs:3244
7 xul.dll webrender_bindings::bindings::wr_renderer_render gfx/webrender_bindings/src/bindings.rs:614
8 xul.dll mozilla::wr::RendererOGL::UpdateAndRender gfx/webrender_bindings/RendererOGL.cpp:193
9 xul.dll mozilla::wr::RenderThread::UpdateAndRender gfx/webrender_bindings/RenderThread.cpp:488

Comment 1

[Sotaro Ikeda [:sotaro]]

All crashes had the following GraphicsCriticalError message.

Failed to initialize DCTile: 00

• https://searchfox.org/mozilla-central/rev/8883276967d39918e2ce64e873afdd432fb406ca/gfx/webrender_bindings/DCLayerTree.cpp#605

Comment 2

[Sotaro Ikeda [:sotaro]]

It could happen only when tile size is not correct.

• https://searchfox.org/mozilla-central/rev/8883276967d39918e2ce64e873afdd432fb406ca/gfx/webrender_bindings/DCLayerTree.cpp#932

Comment 3

[Sotaro Ikeda [:sotaro]]

Tile size is set in DCLayerTree::CreateSurface()

Comment 4

[Sotaro Ikeda [:sotaro]]

Updated GraphicsCriticalError of crash repors had the following. Then DEBUG_OVERLAY seemed to cause the problem.

TileSize is not positive aId: 18446744073709551615 aTileSize(0,0)

• https://searchfox.org/mozilla-central/rev/8d722de75886d6bffc116772a1db8854e34ee6a7/gfx/wr/webrender/src/composite.rs#864

Comment 5

[Sotaro Ikeda [:sotaro]]

aTileSize(0,0) seemed to happen when RenderCompositorANGLE::GetBufferSize() returned (0, 0).

• https://searchfox.org/mozilla-central/rev/bc9e328cce65d10f648130229c3955660d300067/gfx/wr/webrender/src/renderer.rs#3419

Comment 6

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1681756 - Make RenderCompositorANGLE::GetBufferSize() to be positive with native compositor

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a0f41db4ddb5
Make RenderCompositorANGLE::GetBufferSize() to be positive with native compositor r=mattwoodrow

Comment 8

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/a0f41db4ddb5

Comment 9

[Sotaro Ikeda [:sotaro]]

D100220 had a silly mistake :(

Comment 10

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1681756 - Fix return of RenderCompositorANGLE::GetBufferSize()

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6f144aa78811
Fix return of RenderCompositorANGLE::GetBufferSize() r=nical

Comment 12

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/6f144aa78811