1681769 - In-process MessageChannel connections not correctly setting pids, causing crashes in IPC logging

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[(No longer employed by Mozilla) Aaron Klotz]

STR:

Start Fenix with logging for PUiCompositorControllerParent enabled.

From what I can see, we're calling UiCompositorControllerChild::OpenForSameProcess. The pid is set correctly in the child actor, but it is not propagated to the parent actor. When logging PUiCompositorControllerParent, that code calls OtherPid and we release assert.

Comment 1

[Andrew McCreight [:mccr8]]

Looking at InProcessParent::Startup() , maybe it is the responsibility of UiCompositorControllerParent to call SetOtherProcessId()?

Comment 2

[Andrew McCreight [:mccr8]]

Maybe it could be done in UiCompositorControllerParent::InitializeForSameProcess().

Comment 3

[(No longer employed by Mozilla) Aaron Klotz]

I'll take this.

Comment 4

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Bug 1681769: Set UiCompositorControllerParent's "other" pid when initializing for in-process; r=botond

If we don't set UiCompositorControllerParent's other pid during in-process
initialization, we release assert when trying to log IPDL traffic via
MOZ_IPC_MESSAGE_LOG.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9bf6a4637ee8
Set UiCompositorControllerParent's "other" pid when initializing for in-process; r=botond

Comment 6

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/9bf6a4637ee8