Prevent superfluous PictureInPictureParent actors from being associated with each tab
Categories
(Firefox :: Untriaged, defect)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox86 | --- | fixed |
People
(Reporter: whjones526, Assigned: whjones526, NeedInfo)
References
(Blocks 3 open bugs)
Details
Attachments
(1 file)
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:83.0) Gecko/20100101 Firefox/83.0
|
||
Updated•3 years ago
|
|
|
||
Updated•3 years ago
|
|
||
Comment 1•3 years ago
|
||
So I think this is due to the code at https://searchfox.org/mozilla-central/rev/4415bec7a49c50a338167d9c8934527b9cae59d0/toolkit/components/pictureinpicture/PictureInPicture.jsm#323-325 which will get the parent actor when handling a request to enter PiP.
This is odd because AFAICT we only use the ref for a check for where to position things (via a map) -- but it's not the right actor for that anyway, as it doesn't correspond to the player window. But it's quite possible I'm misunderstanding that part...
|
Assignee | |
Comment 2•3 years ago
|
||
|
|
Assignee | |
Comment 3•3 years ago
|
||
(In reply to :Gijs (he/him) from comment #1)
So I think this is due to the code at https://searchfox.org/mozilla-central/rev/4415bec7a49c50a338167d9c8934527b9cae59d0/toolkit/components/pictureinpicture/PictureInPicture.jsm#323-325 which will get the parent actor when handling a request to enter PiP.
This is odd because AFAICT we only use the ref for a check for where to position things (via a map) -- but it's not the right actor for that anyway, as it doesn't correspond to the player window. But it's quite possible I'm misunderstanding that part...
This is correct, I erroneously added this in a previous patch to keep the code as similar as possible to what it already was. I plan to remove this now.
Hi Hunter,
As per your last comment I see that the issue has been solved. For this reason I'll mark this ticket as Resolved - Works for me.
If the issue is still reproducible with the latest Firefox version, feel free to reopen the bug with more information.
Regards,
Virginia
|
|
||
Comment 5•3 years ago
|
||
I think Hunter was referring to a line of code that had been added in a previous patch (one in bug 1589680). I think this bug is still valid - I'm going to re-open.
|
|
||
Comment 6•3 years ago
|
||
Hey Hunter, there's a small nit left on the patch that we hope can be addressed before it lands. Got time for it?
|
|
||
Updated•3 years ago
|
Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/f7fd3b38dfff Prevent superfluous PictureInPictureParent actors from being associated with each tab r=Gijs
|
||
Comment 8•3 years ago
|
||
| bugherder | ||
Description
•