Closed Bug 1681891 Opened 4 years ago Closed 4 years ago

Print preview - focus ring not triggered on-click

Categories

(Toolkit :: Printing, defect, P3)

defect

Tracking

()

RESOLVED WONTFIX
Tracking Status
firefox-esr78 --- unaffected
firefox83 --- wontfix
firefox84 --- wontfix
firefox85 --- wontfix
firefox86 --- wontfix
firefox87 --- wontfix

People

(Reporter: cfogel, Unassigned)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Affected versions

  • 85.0a1(2020-12-10); 84.0;

Affected platforms

  • macOS 10.15;

Steps to reproduce

  1. Launch Firefox, access any page;
  2. CTRL+P to trigger print preview;
  3. Click on either Portrait/Landscape button(s);
  4. Press the Left-Right keys on the keyboard;

Expected result

  • toggle between Landscape/Portrait is working;

Actual result

  • keyboard (left/right arrow) toggle between Landscape/Portrait is not working;

Regression range

  • First bad: 2020-07-21;
  • Last good: 2020-07-20;
  • Pushlog: URL;
  • Potential regressor: visible with addition of this section in the new modal - bug 1652861;

Additional notes

  • S4 as suggested severity;
  • attached recording to illustrate the issue;
  • later edit: not reproducible on Windows 10, Ubuntu 20.
Has Regression Range: --- → yes
Has STR: --- → yes
Component: Print Preview → Printing
Product: Core → Toolkit

Can we set a priority/severity on this?

Flags: needinfo?(mstriemer)

I think this is the expected behaviour on macOS. Clicking a form element doesn't focus it there, but on Windows it should (but we hide the focus styles).

On Windows/Ubuntu when I click a portrait/landscape button I can switch between them with the arrow keys, but on macOS the arrow keys do nothing. The same behaviour can be seen with the sidebar items in about:addons (click then up/down to move, works on Linux/Win but not macOS) or the types of trackers blocked in about:addons (this is actually backed by radio inputs like the landscape/portrait buttons here).

Is this still reproducing for you on Windows/Linux? If it isn't then I think this is fixed.

Severity: -- → S4
Flags: needinfo?(mstriemer) → needinfo?(cristian.fogel)
Priority: -- → P3

Indeed it is limited to macOS, string wasn't updated from my template.
Did a double check anyway and it is limited to macOS.

Now, as far as consistency could we swap this into an enhancement suggestion and probably run it by UX?
As it might be a bit more intuitive, even though it's borderline edge-case use scenario.

Or it's intended as is? In that case, indeed we can close the bug.

Flags: needinfo?(cristian.fogel) → needinfo?(mstriemer)

Sounds like this is the expected behaviour on macOS then. I don't think we should diverge from how these inputs would normally behave there.

Status: NEW → RESOLVED
Closed: 4 years ago
Flags: needinfo?(mstriemer)
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: