Closed Bug 1681893 Opened 6 months ago Closed 5 months ago

Remove defer usage in devtools/server/tests/xpcshell/head_dbg.js

Categories

(DevTools :: Shared Components, task, P3)

Product:
DevTools
Component:
Shared Components
Type:
task

Tracking

(firefox86 fixed)

Status:
RESOLVED FIXED
Milestone:
86 Branch
Tracking Flags:
Tracking Status
firefox86 --- fixed

People

(Reporter: Honza, Assigned: pedrofonsecadev)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug)

Attachments

(1 file, 3 obsolete files)

Bug 1681893 -[devtools] Remove defer usage in devtools/server/tests/xpcshell/head_dbg.js r=nchevobbe
48 bytes, text/x-phabricator-request
Details | Review

We should use new Promise instead.

Honza

Hi
Can I work on this bug ?

hey, Is it still a bug? Can I work on this issue?

Flags: needinfo?(odvarko)
Assignee: nobody → pedrofonsecadev
Status: NEW → ASSIGNED

Hey guys,
I didn't know who I should add as reviewers, because I didn't find "Shared Components" on the module list.

If I did something wrong please let me know about it.

Thanks.
Pedro

Pushed by jodvarko@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c17d361450d3
[devtools] Remove defer usage in devtools/server/tests/xpcshell/head_dbg.js r=Honza

Backed out changeset c17d361450d3 (Bug 1681893) for causing eslint failures in test_nesting-<01/02>.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/e130ea91df85a44be150630badfe7cc06c27330f

Failure log: https://treeherder.mozilla.org/logviewer?job_id=325962418&repo=autoland&lineNumber=510

Flags: needinfo?(pedrofonsecadev)
Flags: needinfo?(odvarko)

Should I remove the tests as well?

Flags: needinfo?(pedrofonsecadev) → needinfo?(malexandru)

(In reply to pedrofonsecadev from comment #7)

Should I remove the tests as well?

The two tests need to be updated as Nicolas explains in https://phabricator.services.mozilla.com/D100880#3275512

Flags: needinfo?(malexandru) → needinfo?(pedrofonsecadev)
Attachment #9196209 - Attachment is obsolete: true
Attachment #9195577 - Attachment is obsolete: true
Attachment #9195577 - Attachment is obsolete: false
Attachment #9196167 - Attachment is obsolete: true
Attachment #9195577 - Attachment is obsolete: true
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/28b8ca785fbb
[devtools] Remove defer usage in devtools/server/tests/xpcshell/head_dbg.js r=nchevobbe

https://hg.mozilla.org/mozilla-central/rev/28b8ca785fbb

Status: ASSIGNED → RESOLVED
Closed: 5 months ago
status-firefox86: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 86 Branch
Flags: needinfo?(pedrofonsecadev)
You need to log in before you can comment on or make changes to this bug.