168191 - Checksetup needs to force template recompilation

Status: RESOLVED FIXED

(Bugzilla :: User Interface, defect)

Description

[Joel Peshkin]

The template toolkit seems to assume that, if the data/template/.... file is
newer than the template/... file, that it is current.  Unfortunately, especially
with sites practicing version control, this is not a safe assumption.  
checksetup should force data/template/... to be rebuilt from scratch.

To get burned by this, check out and run 2.16
Then, check out and run 2.14
Now you have data/params from 2.14 and data/template from 2.16
Then check out HEAD and run it
You will die because you have a nice new data/template from 2.16 and a
template/... from HEAD that is probably a few days old.

Comment 1

[Bradley Baetz (:bbaetz)]

Attachment: try this

Note that we're going to have to do this anyway once we start using the TT
compile-time constant stuff.

The other change is to use Template::Provider to precompile this for us, so
that we don't run the template, only compile it. This gives a (small) speed
improvment in checksetup/tests, plus it makes bug 126955 easier.

Comment 2

[Bradley Baetz (:bbaetz)]

-> me

Comment 3

[Bradley Baetz (:bbaetz)]

gerv checked this in for me, r=him x2, in order to fix tbox, which was red
because some of the templates now USE a module which may not be present. The
.cgi schecks for it, but the plugin can't....