Closed Bug 168191 Opened 22 years ago Closed 22 years ago

Checksetup needs to force template recompilation

Categories

(Bugzilla :: User Interface, defect)

2.17
x86
Other
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Bugzilla 2.18

People

(Reporter: bugreport, Assigned: bbaetz)

Details

Attachments

(1 file)

The template toolkit seems to assume that, if the data/template/.... file is newer than the template/... file, that it is current. Unfortunately, especially with sites practicing version control, this is not a safe assumption. checksetup should force data/template/... to be rebuilt from scratch. To get burned by this, check out and run 2.16 Then, check out and run 2.14 Now you have data/params from 2.14 and data/template from 2.16 Then check out HEAD and run it You will die because you have a nice new data/template from 2.16 and a template/... from HEAD that is probably a few days old.
Target Milestone: --- → Bugzilla 2.18
Attached patch try thisSplinter Review
Note that we're going to have to do this anyway once we start using the TT compile-time constant stuff. The other change is to use Template::Provider to precompile this for us, so that we don't run the template, only compile it. This gives a (small) speed improvment in checksetup/tests, plus it makes bug 126955 easier.
-> me
Assignee: myk → bbaetz
Keywords: patch, review
gerv checked this in for me, r=him x2, in order to fix tbox, which was red because some of the templates now USE a module which may not be present. The .cgi schecks for it, but the plugin can't....
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: