Closed Bug 1681994 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 26857 - Fix flaky test about COEP.

Categories

(Core :: DOM: Core & HTML, task, P4)

task

Tracking

()

RESOLVED FIXED
86 Branch
Tracking Status
firefox86 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 26857 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/26857
Details from upstream follow.

b'arthursonzogni <arthursonzogni@chromium.org>' wrote:

Fix flaky test about COEP.

This patch reverts previous attempt fixing this:
https://chromium-review.googlesource.com/c/chromium/src/+/2402719

Two problems have been found:

  1. The test expected the load event to be triggered twice. One for the
    initial load, then the child document navigates itself, which caused
    a second load event to be dispatched.
    The problem: the navigation might start before the load event. Those
    are known as "client-side" redirect. The test fails because it
    received only one load event. Solution is to wait for the load event
    to be dispatched before initiating the navigation.

  2. One test was doing weird things with several navigations triggered in
    parallel (history.back() in the window + regular navigation).
    Moreover the history.back() navigation was going toward a document
    that navigate itself (again).
    Solution was to rewrite the test.

Bug: 1013596
Change-Id: I1cbbbcf07a91e8beb220d688fb1e39f6559277cd

Reviewed-on: https://chromium-review.googlesource.com/2584850
WPT-Export-Revision: cc6913b7ca001f1d7edb7c5c42141ff96fc93112

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 14 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 3 tests and 16 subtests

Status Summary

Firefox

OK : 3
PASS : 25

Chrome

OK : 3
PASS : 25

Safari

OK : 2
PASS : 8
FAIL : 16
TIMEOUT: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d9170ac53e78 [wpt PR 26857] - Fix flaky test about COEP., a=testonly
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 86 Branch
You need to log in before you can comment on or make changes to this bug.