Switch eye-dropper's getWindowAsImageData from drawWindow to drawSnapshot for Fission
Categories
(DevTools :: Inspector, task)
Tracking
(Fission Milestone:Future)
Fission Milestone | Future |
People
(Reporter: smacleod, Unassigned)
References
(Blocks 2 open bugs)
Details
CanvasRenderingContext2D.drawWindow() is synchronous and won't work with fission, so eye-dropper.js[1] must be updated to use the asynchronous drawSnapshot[2]
Assignee | ||
Updated•4 years ago
|
Comment 2•4 years ago
|
||
Sending this bug to dt-fission triage. Should we fix this bug for Fission MVP? We were tracking this bug for Fission MVP milestone, but it didn't have a dt-fission
whiteboard tags.
Also, if we want to fix this bug before shipping Fission, we should fix it in our Fission M8 milestone. (The Fission MVP milestone is now intended for tracking meta bugs and last minute fixes.)
The eye dropper is already making use of drawSnapshot
since Bug 1568831.
We only keep the call to drawWindow
as a safety net in case there was an issue when calling drawSnapshot
.
Comment 4•4 years ago
|
||
(In reply to Nicolas Chevobbe [:nchevobbe] from comment #3)
The eye dropper is already making use of
drawSnapshot
since Bug 1568831.
We only keep the call todrawWindow
as a safety net in case there was an issue when callingdrawSnapshot
.
In that case, can we resolve this bug as WONTFIX?
If someone eventually removes the drawWindow
API itself (bug 1682545), they will remove the eye dropper's use of drawWindow
then.
Sure, I'll dupe this one
Updated•4 years ago
|
Description
•