Open Bug 1682038 Opened 3 years ago Updated 3 years ago

Patreon password reset doesn't have "Use generated password" option

Categories

(Toolkit :: Password Manager: Site Compatibility, defect, P3)

Product:
Toolkit
Component:
Password Manager: Site Compatibility
Type:
defect

Tracking

()

People

(Reporter: jrmuizel, Unassigned)

References

(
URL
)

Details

(Whiteboard: [passwords:generation])

Attachments

(1 file)

Password Reset.png
78.97 KB, image/png
Details

Here are some logs:

LoginManagerChild: onDOMInputPasswordAdded, visibilityState: visible isMasterPasswordSet: false LoginManagerChild.jsm:853:8
LoginFormFactory: Created non-form LoginForm for rootElement: 
<html>
LoginFormFactory.jsm:120:9
LoginFormFactory: adding 
<html> to root elements for 
HTMLDocument file:///private/tmp/test.html
LoginFormFactory.jsm:129:9
LoginManagerChild:  _processDOMInputPasswordAddedEvent: 
<input type="password"> 
Object { action: "file://", autocomplete: "on", ownerDocument: HTMLDocument file:///private/tmp/test.html, rootElement: html
, elements: Getter, … }
LoginManagerChild.jsm:877:8
LoginManagerChild: Creating a DeferredTask to call _fetchLoginsFromParentAndFillForm soon LoginManagerChild.jsm:883:10
LoginManagerChild: Arming the DeferredTask we just created since document.readyState == 'interactive' or 'complete' LoginManagerChild.jsm:923:10
LoginFormFactory: Created non-form LoginForm for rootElement: 
<html>
LoginFormFactory.jsm:120:9
LoginFormFactory: adding 
<html> to root elements for 
HTMLDocument file:///private/tmp/test.html
LoginFormFactory.jsm:129:9
LoginManagerChild: Running deferred processing of onDOMInputPasswordAdded 
Object { action: "file://", autocomplete: "on", ownerDocument: HTMLDocument file:///private/tmp/test.html, rootElement: html
, elements: Getter, … }
LoginManagerChild.jsm:895:14
LoginManager: searchLoginsAsync: 
Object { origin: "file://", schemeUpgrades: true, acceptDifferentSubdomains: true }
LoginManager.jsm:508:9
Login storage: searchLoginsAsync: 
Object { origin: "file://", schemeUpgrades: true, acceptDifferentSubdomains: true }
storage-json.js:447:10
Login storage: _searchLogins: returning 0 logins for 
Object { origin: "file://" }
 with options 
Object { acceptDifferentSubdomains: true, schemeUpgrades: true }
storage-json.js:633:10
LoginManagerParent: sendLoginDataToChild: 0 deduped logins LoginManagerParent.jsm:544:8
LoginRecipes: cacheRecipes: for: file:// LoginRecipes.jsm:263:9
LoginManagerChild: _fillForm 
Array [ input
 ]
LoginManagerChild.jsm:2144:8
LoginRecipes: _filterRecipesForForm 
Set []
LoginRecipes.jsm:314:9
LoginRecipes: getFieldOverrides: filtered recipes: 0 
Set []
LoginRecipes.jsm:342:9
LoginManagerChild: (form -- no username field found) LoginManagerChild.jsm:1408:10
LoginManagerChild: Password field 
<input type="password">
 has name:  <empty string> LoginManagerChild.jsm:1454:10
debuggee 'resource://devtools/shared/base-loader.js:289' would run builtin-modules.js:196:11
LoginFormFactory: Created non-form LoginForm for rootElement: 
<html>
LoginFormFactory.jsm:120:9
LoginFormFactory: adding 
<html> to root elements for 
HTMLDocument file:///private/tmp/test.html
LoginFormFactory.jsm:129:9
LoginAutoComplete: LoginAutoComplete search: 
Object { forcePasswordGeneration: false, isSecure: true, hasBeenTypePassword: true, isProbablyANewPasswordField: false, searchString: "" }
LoginAutoComplete.jsm:693:9
LoginManagerParent: Creating new autocomplete search result. LoginManagerParent.jsm:607:10
LoginManager: searchLoginsAsync: 
Object { origin: "file://", schemeUpgrades: true, acceptDifferentSubdomains: true }
LoginManager.jsm:508:9
Login storage: searchLoginsAsync: 
Object { origin: "file://", schemeUpgrades: true, acceptDifferentSubdomains: true }
storage-json.js:447:10
Login storage: _searchLogins: returning 0 logins for 
Object { origin: "file://" }
 with options 
Object { acceptDifferentSubdomains: true, schemeUpgrades: true }
storage-json.js:633:10
LoginAutoComplete: Hiding footer: no logins and the popup was opened upon focus of the pw. field LoginAutoComplete.jsm:327:11
LoginFormFactory: Created non-form LoginForm for rootElement: 
<html>
LoginFormFactory.jsm:120:9
LoginFormFactory: adding 
<html> to root elements for 
HTMLDocument file:///private/tmp/test.html
LoginFormFactory.jsm:129:9
LoginRecipes: _filterRecipesForForm 
Set []
LoginRecipes.jsm:314:9
LoginRecipes: getFieldOverrides: filtered recipes: 0 
Set []
LoginRecipes.jsm:342:9
LoginManagerChild: (form -- no username field found) LoginManagerChild.jsm:1408:10
LoginManagerChild: Password field 
<input type="password">
 has name:  <empty string> LoginManagerChild.jsm:1454:10
LoginManager: Checking if logins to file:// can be saved. LoginManager.jsm:579:9
LoginManager: Searching for logins LoginManager.jsm:521:9
Login storage: _searchLogins: returning 0 logins for 
Object { origin: "file://" }
 with options 
Object { schemeUpgrades: true }
storage-json.js:633:10
LoginFormFactory: Created non-form LoginForm for rootElement: 
<html>
LoginFormFactory.jsm:120:9
LoginFormFactory: adding 
<html> to root elements for 
HTMLDocument file:///private/tmp/test.html
LoginFormFactory.jsm:129:9
LoginAutoComplete: LoginAutoComplete search: 
Object { forcePasswordGeneration: true, isSecure: true, hasBeenTypePassword: true, isProbablyANewPasswordField: false, searchString: "" }
LoginAutoComplete.jsm:693:9
LoginManagerParent: Creating new autocomplete search result. LoginManagerParent.jsm:607:10
LoginManager: searchLoginsAsync: 
Object { origin: "file://", schemeUpgrades: true, acceptDifferentSubdomains: true }
LoginManager.jsm:508:9
Login storage: searchLoginsAsync: 
Object { origin: "file://", schemeUpgrades: true, acceptDifferentSubdomains: true }
storage-json.js:447:10
Login storage: _searchLogins: returning 0 logins for 
Object { origin: "file://" }
 with options 
Object { acceptDifferentSubdomains: true, schemeUpgrades: true }
storage-json.js:633:10
LoginManager: searchLoginsAsync: 
Object { origin: "file://", formActionOrigin: "file://", httpRealm: null }
LoginManager.jsm:508:9
Login storage: searchLoginsAsync: 
Object { origin: "file://", formActionOrigin: "file://", httpRealm: null }
storage-json.js:447:10
Login storage: _searchLogins: returning 0 logins for 
Object { httpRealm: null, formActionOrigin: "file://", origin: "file://" }
 with options 
Object {  }
storage-json.js:633:10
Content Security Policy: Ignoring “'unsafe-inline'” within script-src: ‘strict-dynamic’ specified
Content Security Policy: Ignoring “https:” within script-src: ‘strict-dynamic’ specified
Content Security Policy: Ignoring “http:” within script-src: ‘strict-dynamic’ specified
Content Security Policy: Ignoring “'unsafe-inline'” within script-src: ‘strict-dynamic’ specified
Content Security Policy: Ignoring “https:” within script-src: ‘strict-dynamic’ specified
Content Security Policy: Ignoring “http:” within script-src: ‘strict-dynamic’ specified
LoginFormFactory: adding 
<form class="mb-md"> to root elements for 
HTMLDocument https://www.patreon.com/forgetPassReset?u=358769&sec=57665e827805fdd51b6b50f8da45f004
LoginFormFactory.jsm:68:9
LoginAutoComplete: LoginAutoComplete search: 
Object { forcePasswordGeneration: false, isSecure: true, hasBeenTypePassword: true, isProbablyANewPasswordField: false, searchString: "" }
LoginAutoComplete.jsm:693:9
LoginManagerParent: Creating new autocomplete search result. LoginManagerParent.jsm:607:10
LoginManager: searchLoginsAsync: 
Object { origin: "https://www.patreon.com", schemeUpgrades: true, acceptDifferentSubdomains: true }
LoginManager.jsm:508:9
Login storage: searchLoginsAsync: 
Object { origin: "https://www.patreon.com", schemeUpgrades: true, acceptDifferentSubdomains: true }
storage-json.js:447:10
Login storage: _searchLogins: returning 0 logins for 
Object { origin: "https://www.patreon.com" }
 with options 
Object { acceptDifferentSubdomains: true, schemeUpgrades: true }
storage-json.js:633:10
LoginAutoComplete: Hiding footer: no logins and the popup was opened upon focus of the pw. field LoginAutoComplete.jsm:327:11
LoginFormFactory: adding 
<form class="mb-md"> to root elements for 
HTMLDocument https://www.patreon.com/forgetPassReset?u=358769&sec=57665e827805fdd51b6b50f8da45f004
LoginFormFactory.jsm:68:9
LoginRecipes: _filterRecipesForForm 
Set []
LoginRecipes.jsm:314:9
LoginRecipes: getFieldOverrides: filtered recipes: 0 
Set []
LoginRecipes.jsm:342:9
LoginManagerChild: (form -- no username field found) LoginManagerChild.jsm:1408:10
LoginManagerChild: Password field 
<input class="sc-oTbqq jIrrfO" aria-invalid="false" aria-labelledby="TextInput-0-label TextInput-0-prefix" aria-multiline="false" name="password" type="password" value="">
 has name:  password LoginManagerChild.jsm:1454:10
LoginManager: Checking if logins to https://www.patreon.com can be saved. LoginManager.jsm:579:9
LoginManager: Searching for logins LoginManager.jsm:521:9
Login storage: _searchLogins: returning 0 logins for 
Object { origin: "https://www.patreon.com" }
 with options 
Object { schemeUpgrades: true }

In the password reset page, "Use a Securely Generated Password" occurs in the Confirmed Password field but not in the Password field.
This is related to whether the Fathom model considers the filed a new password field here.

Attached image Password Reset.png —

Not sure if this helps, here are the rules that match and its corresponding coefficient

Password:
nextInputIsConfirmy: coefficient(2.5108766555786133)
forgotPasswordOnPageButtonTextContent: coefficient(-0.0006637098849751055)
forgotPasswordOnPageLinkHref: coefficient(-0.3587746322154999)
forgotPasswordInFormButtonTextContent: coefficient(-2.2410218715667725)
final score = 0.49837951252854834

Confirmed Password field:
elementAttrsMatchConfirm: coefficient(1.79710853099823)
forgotPasswordOnPageButtonTextContent: coefficient(-0.0006637098849751055)
forgotPasswordOnPageLinkHref: coefficient(-0.3587746322154999)
forgotPasswordInFormButtonTextContent: coefficient(-2.2410218715667725)
closestLabelMatchesConfirm: coefficient(2.188796281814575)
hasConfirmLabel: coefficient(1.9212454557418823)
final score = 0.9673839711245802

This might be a good candidate for adding to the training data we use the the new password field Fathom model.

Severity: -- → S3
Priority: -- → P3
Whiteboard: [passwords:generation]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: