1682141 - Crash in [@ mozilla::dom::DocGroup::ReportPerformanceInfo]

Status: RESOLVED FIXED

(Core :: Performance: General, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Crash report: https://crash-stats.mozilla.org/report/index/4118bc31-71ad-4fa5-97f2-060440201212

Reason: EXCEPTION_ACCESS_VIOLATION_READ

Top 10 frames of crashing thread:

0 xul.dll mozilla::dom::DocGroup::ReportPerformanceInfo dom/base/DocGroup.cpp:251
1 xul.dll mozilla::CollectPerformanceInfo toolkit/components/perfmonitoring/PerformanceUtils.cpp:50
2 xul.dll mozilla::dom::ContentChild::RecvRequestPerformanceMetrics dom/ipc/ContentChild.cpp:1448
3 xul.dll mozilla::dom::PContentChild::OnMessageReceived ipc/ipdl/PContentChild.cpp:9375
4 xul.dll mozilla::ipc::MessageChannel::DispatchMessage ipc/glue/MessageChannel.cpp:2077
5 xul.dll mozilla::TaskController::DoExecuteNextTaskOnlyMainThreadInternal xpcom/threads/TaskController.cpp:732
6 xul.dll nsThread::ProcessNextEvent xpcom/threads/nsThread.cpp:1200
7 xul.dll mozilla::ipc::MessagePump::Run ipc/glue/MessagePump.cpp:109
8 xul.dll MessageLoop::RunHandler ipc/chromium/src/base/message_loop.cc:327
9 xul.dll MessageLoop::Run ipc/chromium/src/base/message_loop.cc:309

Comment 1

[Andreas Farre [:farre]]

Attachment: Bug 1682141 - Stop searching for top window if there is no top window. r=peterv

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6713504bad2d
Stop searching for top window if there is no top window. r=peterv

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/6713504bad2d

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Please request an uplift for beta.

Comment 5

[[:philipp]]

crashes on 86 nightly are still continuing with the patch though...

Comment 6

[Andreas Farre [:farre]]

Attachment: Bug 1682141: Stop searching for top window if top contex has no window context. r=smaug!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c9f9c4007739
Stop searching for top window if top contex has no window context. r=smaug

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/c9f9c4007739

Comment 9

[Andreas Farre [:farre]]

Comment on attachment 9193002 [details]
Bug 1682141 - Stop searching for top window if there is no top window. r=peterv

Beta/Release Uplift Approval Request

• User impact if declined: Bad code in beta.
• Is this code covered by automated tests?: Unknown
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small change that doesn't change behavior, only adds checks.
• String changes made/needed:

Comment 10

[Julien Cristau [:jcristau] (back August 18)]

Comment on attachment 9193002 [details]
Bug 1682141 - Stop searching for top window if there is no top window. r=peterv

approved for 85.0b5

Comment 11

[Julien Cristau [:jcristau] (back August 18)]

https://hg.mozilla.org/releases/mozilla-beta/rev/97dfda000f2b
https://hg.mozilla.org/releases/mozilla-beta/rev/fc05a83d3ebd