1682146 - ClearCache bitflags are all identical

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P3)

Description

[Andrew Osmond [:aosmond] (he/him)]

The bitflags all use the same bit here:

https://searchfox.org/mozilla-central/rev/95cf843de977805a3951f9137f5ff1930599d94e/gfx/wr/webrender/src/render_api.rs#879

as 0b1, 0b01, 0b001, etc are equivalent. It should be 0b1, 0b10, 0b100, etc.

This doesn't appear to cause any actual problems since we appear to only clear everything in the cache anyways via ClearCache::all().

Comment 1

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 1682146 - Fix how ClearCache bits in WebRender were all the same.

This should not have a functional change because today nothing uses the
individual flags and instead always uses ClearCache::all().

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3c36156a38e3
Fix how ClearCache bits in WebRender were all the same. r=jrmuizel

Comment 3

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/3c36156a38e3