Fix touch-action:pinch-zoom support in TouchActionHelper
Categories
(Core :: Panning and Zooming, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr78 | --- | unaffected |
firefox84 | --- | unaffected |
firefox85 | --- | fixed |
firefox86 | --- | fixed |
People
(Reporter: kats, Assigned: kats)
References
Details
Attachments
(1 file)
47 bytes,
text/x-phabricator-request
|
jcristau
:
approval-mozilla-beta+
|
Details | Review |
This needs fixing for proper support of touch-action:pinch-zoom. I forgot about this code when I mentored bug 1329241 with the rest of the implementation.
The TouchActionHelper codepath is only used in some fallback scenarios, so I'm not sure if a lot of real world sites would be affected. I only realized the problem due to unrelated code browsing. It's a pretty small fix, I'll try to write a test that exercises the scenario as well. We'll want to uplift to 85 so it rides with bug 1329241.
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 1•4 years ago
|
||
Assignee | ||
Comment 2•4 years ago
|
||
Oops. This should be better: https://treeherder.mozilla.org/#/jobs?repo=try&revision=da4d2a919cd0b5820c243bdec9f8cceb0d20abb8
Assignee | ||
Comment 3•4 years ago
|
||
The code in TouchActionHelper didn't get updated with the
rest of the touch-action:pinch-zoom implementation. This
patch corrects that and adds a test that exercises the
relevant scenario.
Comment 5•4 years ago
|
||
bugherder |
Assignee | ||
Comment 6•4 years ago
|
||
Comment on attachment 9192944 [details]
Bug 1682170 - Update TouchActionHelper to support touch-action:pinch-zoom. r?botond
Beta/Release Uplift Approval Request
- User impact if declined: In some cases, web content with
touch-action:pinch-zoom
may not work as intended. - Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Pretty small, well-understood change. Comes with test.
- String changes made/needed: none
Updated•4 years ago
|
Comment 7•4 years ago
|
||
Comment on attachment 9192944 [details]
Bug 1682170 - Update TouchActionHelper to support touch-action:pinch-zoom. r?botond
approved for 85.0b2
Comment 8•4 years ago
|
||
bugherder uplift |
Description
•