1682193 - Crash in [@ nsBaseContentList::cycleCollection::CanSkipReal] when inspecting with the browser toolbox the print preview from bug 1682159

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P3)

Description

[Emilio Cobos Álvarez (:emilio)]

Maybe Fission related. (DOMFissionEnabled=1)

Crash report: https://crash-stats.mozilla.org/report/index/d30b51c8-24dd-48ba-adfd-b59830201213

Reason: SIGSEGV /SEGV_MAPERR

Top 10 frames of crashing thread:

0 libxul.so nsBaseContentList::cycleCollection::CanSkipReal dom/base/nsContentList.cpp:59
1 libxul.so nsCycleCollector_forgetSkippable xpcom/base/nsCycleCollector.cpp:3858
2 libxul.so FireForgetSkippable dom/base/nsJSEnvironment.cpp:1134
3 libxul.so CCRunnerFired dom/base/nsJSEnvironment.cpp:1639
4 libxul.so mozilla::IdleTaskRunner::Run xpcom/threads/IdleTaskRunner.cpp:54
5 libxul.so mozilla::TaskController::DoExecuteNextTaskOnlyMainThreadInternal xpcom/threads/TaskController.cpp:732
6 libxul.so nsThread::ProcessNextEvent xpcom/threads/nsThread.cpp:1200
7 libxul.so mozilla::ipc::MessagePump::Run ipc/glue/MessagePump.cpp:87
8 libxul.so MessageLoop::Run ipc/chromium/src/base/message_loop.cc:309
9 libxul.so nsBaseAppShell::Run widget/nsBaseAppShell.cpp:137

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1682193 - Don't append null content nodes in InspectorUtils.getOverflowingChildrenOfElement. r=dholbert,#layout-reviewers

And add an assertion for this to fail earlier (in debug builds at
least).

The issue is that in paginated mode canvas frames (which are not
associated to a node) might overflow their page content frame.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a47708d985da
Don't append null content nodes in InspectorUtils.getOverflowingChildrenOfElement. r=dholbert

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/a47708d985da

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9192947 [details]
Bug 1682193 - Don't append null content nodes in InspectorUtils.getOverflowingChildrenOfElement. r=dholbert,#layout-reviewers

Beta/Release Uplift Approval Request

• User impact if declined: Null pointer crashes when inspecting print preview.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): null-check
• String changes made/needed: none

Comment 6

[Julien Cristau [:jcristau]]

Comment on attachment 9192947 [details]
Bug 1682193 - Don't append null content nodes in InspectorUtils.getOverflowingChildrenOfElement. r=dholbert,#layout-reviewers

approved for 85.0b3

Comment 7

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/19f04b862eaf