1682220 - Use nsIWorkerDebugger.windowIds instead of nsIWorkerDebugger.window.windowGlobalChild.innerWindowId in DevToolsWorkerChild

Status: RESOLVED FIXED

(DevTools :: Framework, task, P2)

Description

[Nicolas Chevobbe [:nchevobbe]]

From early testing, the new windowIds property doesn't seem to suffer from the issue we see in Bug 1673024, which mean we can probably remove the ignoreExistingTargets option ( https://searchfox.org/mozilla-central/search?q=ignoreExistingTargets&path=&case=true&regexp=false) we have to work around the original issue

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

TRY seems fine with that: https://treeherder.mozilla.org/jobs?repo=try&revision=38a5a81cb7c5ac85d734b8552c6966de1259e58e&selectedTaskRun=FJQgVLtVTvit6WJV0lNy4A.0

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1682220 - [devtools] Use nsiWorkerDebugger#windowIds instead of window reference in DevToolsWorkerChild. r=ochameau.

This also allow us to remove the ignoreExistingTargets option we had to workaround Bug 1673024.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/acc496d59a30
[devtools] Use nsiWorkerDebugger#windowIds instead of window reference in DevToolsWorkerChild. r=ochameau.

Comment 4

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/acc496d59a30

Comment 5

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f1e52c54a12e
Backed out changeset acc496d59a30 after backing out Bug 1657130 for being its blocker.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cccf4b41b4bc
[devtools] Use nsiWorkerDebugger#windowIds instead of window reference in DevToolsWorkerChild. r=ochameau.

Comment 7

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/cccf4b41b4bc