1682311 - Customize menu animation is not smooth

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P1)

Description

[Erica Wright [:ewright]]

With the pref:

browser.newtabpage.activity-stream.newNewtabExperience.enabled=true
or
browser.newtabpage.activity-stream.customizationMenu.enabled=true

When opening the customize menu, sometimes it jumps and stutters. We should fix this and uplioft to 85 for testing.

Comment 1

[Erica Wright [:ewright]]

Attachment: Bug 1682311 - Make the customization menu animation smooth

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a421fd8b9897
Make the customization menu animation smooth r=prathiksha

Comment 3

[Atila Butkovits]

Backed out for causing failures on browser_customize_menu_content.js .

Backout link: https://hg.mozilla.org/integration/autoland/rev/85c071060feea5e8e87d589ca553aa6c7c7d2ae4

Push with failure: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=FpPN_8XuRVqKUQXKP9F1lQ.0&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&searchStr=linux%2C18.04%2Cx64%2Ctsan%2Copt%2Cmochitests%2Ctest-linux1804-64-tsan%2Fopt-mochitest-browser-chrome-e10s%2Cbc12&revision=a421fd8b98973bcd6569ccc904523105c7282cd6

Failure log: https://treeherder.mozilla.org/logviewer?job_id=324836450&repo=autoland&lineNumber=2866

Comment 4

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/85c071060fee
Backed out changeset a421fd8b9897 for causing failures on browser_customize_menu_content.js . CLOSED TREE

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c48c1da239e3
Make the customization menu animation smooth r=prathiksha

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/c48c1da239e3

Comment 7

[Erica Wright [:ewright]]

Comment on attachment 9193104 [details]
Bug 1682311 - Make the customization menu animation smooth

Beta/Release Uplift Approval Request

• User impact if declined: We intend on doing a limited test wiht the customization menu in 85 on release. the animation when the menu opens stutters a lot on Mac (and possibly other platforms). This fixes that poor experience.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: - flip browser.newtabpage.activity-stream.newNewtabExperience.enabled to true.

• open a tew tab
• click "personalize" button in the top corner
• observe the menu opening
• click close once the menu opens
• observe the menu closing

The open and close animation should be smooth.

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is a small change and is behind a pref. We plan on running a limited test on release.
• String changes made/needed: none

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9193104 [details]
Bug 1682311 - Make the customization menu animation smooth

Approved for 85.0b4.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/d0fea4653eef

Comment 10

[Robert Martin [:romartin], Ecosystem QA]

I have verified that the "Customize menu" animation is smooth by following the steps provided in comment 7 using Firefox Beta 85.0b4 (Build ID: 20201220193140) and Firefox Nightly 86.0a1 (Build ID: 20201220093524) on Windows 10 x64, macOS 10.15.6, and Ubuntu Linux 20.04 x64.