1682372 - Remove unused fields in the Pocket impression ping

Status: VERIFIED FIXED

(Firefox :: New Tab Page, enhancement, P1)

Description

[Nan Jiang [:nanj]]

As reported in bug 1682360 and bug 1682366, various fields (client_id, session_id, action) in the Pocket impression ping & SPOCS fill are not tracked by the table schema. Most of them are not applicable and set to "n/a", we should remove those fields from the payload so the sent pings are matching against the schema.

Comment 1

[Nan Jiang [:nanj]]

Kirill or Scot, are we still using the spocs_fill ping? If not, perhaps we'd better deprecate this ping now.

Comment 2

[Kirill Demtchouk]

Deprecate-away! This ping is no longer needed.

Comment 3

[Nan Jiang [:nanj]]

Sounds good! Will file a separate bug to track that.

Comment 4

[Scott [:thecount] Downe]

Clearing needinfo, Kirill got me covered.

Comment 5

[Nan Jiang [:nanj]]

Attachment: Bug 1682372 - Remove unused fields in the impression stats ping r=thecount

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bcfbf7c9d108
Remove unused fields in the impression stats ping r=thecount

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/bcfbf7c9d108

Comment 8

[Marius Coman [:mcoman], Ecosystem QA]

I have verified this enhancement and I can confirm that the client_id, session_id, and action fields are no longer displayed inside the "Pocket Impression" ping from the "Browser Console".

Verified using the latest Firefox Nightly (86.0a1 Build ID - 20210118094603) installed on Windows 10 x64, Mac 10.15.7, and Linux Mint 20 x64.