1682439 - Implement CSS contrast-color() function

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[709922234]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:85.0) Gecko/20100101 Firefox/85.0

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 3

[Sebastian Zartner [:sebo]]

It was resolved today to rename this function to contrast-color(). So renaming this bug as well.
(Also, the function got postponed to level 6 of the specification, though there is no draft yet so keeping it at level 5 for now.)

Sebastian

Comment 4

[BenjaminAster]

(In reply to Sebastian Zartner [:sebo] from comment #3)

(Also, the function got postponed to level 6 of the specificaction, though there is no draft yet so keeping it at level 5 for now.)

There is a draft of css-color-6: drafts.csswg.org/css-color-6. I guess the CSSWG just forgot to link it in their drafts overview (drafts.csswg.org). You can actually find it at the bottom of the drafts overview under "Other Documents".

Comment 5

[Sebastian Zartner [:sebo]]

Thanks for the hint, Benjamin! I've also asked the CSSWG to add it to the specifications list.

Sebastian

Comment 6

[Woody Li]

color-contrast() has been renamed to contrast-color() and syntax changed.

https://github.com/w3c/csswg-drafts/issues/7557
https://drafts.csswg.org/css-color-6/#resolving-contrast

Comment 7

[Sebastian Zartner [:sebo]]

(In reply to Woody Li from comment #6)

color-contrast() has been renamed to contrast-color()

Yes, I mentioned that earlier.

and syntax changed.

And the syntax discussion is still not finished, see https://github.com/w3c/csswg-drafts/issues/7937.

Sebastian

Comment 8

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1682439 - Implement CSS contrast-color() function. r=#style

This implements the contrast-color() function from CSS Color 5
(https://drafts.csswg.org/css-color-5/#contrast-color).

The extended version proposed in CSS Color 6 is not sufficiently well spec'd
to consider implementing at this time.

Comment 9

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1682439 - Add a basic WPT reftest for results of the contrast-color() function. r=#style

Comment 10

[Sebastian Zartner [:sebo]]

Making this block CSS Color 5 again instead of level 6. Once implemented, this needs to be documented. So adding the dev-doc-needed flag. It should also be mentioned in the dev and general release notes.

Release Note Request (optional, but appreciated)
[Why is this notable]: New CSS function for automatically choosing a contrasting color.
[Affects Firefox for Android]: yes
[Suggested wording]: Firefox now supports the contrast-color() CSS function that takes a color value and returns a contrasting color. Note that the specification currently restricts the contrasting color to black or white. This limitation is expected to be removed in the future.
[Links (documentation, blog post, etc)]:
https://developer.mozilla.org/en-US/docs/Web/CSS/color_value/contrast-color
https://drafts.csswg.org/css-color-5/#contrast-color

Sebastian

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f4fa1425b081
https://hg.mozilla.org/integration/autoland/rev/0c13bf616ac7
Implement CSS contrast-color() function. r=firefox-style-system-reviewers,emilio,tlouw
https://github.com/mozilla-firefox/firefox/commit/69695ad2db5c
https://hg.mozilla.org/integration/autoland/rev/34056693c143
Add a basic WPT reftest for results of the contrast-color() function. r=firefox-style-system-reviewers,emilio

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/ab91e25575a5
https://hg.mozilla.org/integration/autoland/rev/ab41c4c5cac8
Revert "Bug 1682439 - Add a basic WPT reftest for results of the contrast-color() function. r=firefox-style-system-reviewers,emilio" for causing mochitests failures in test_bug877690.html.

Comment 13

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/55713 for changes under testing/web-platform/tests

Comment 14

[Serban Stanca [:SerbanS]]

Reverted this because it was causing mochitests failures in test_bug877690.html.

• Revert link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | layout/inspector/tests/test_bug877690.html | property color's values.

Comment 15

[Jonathan Kew [:jfkthame]]

Yeah, I saw this -- we just need to update that test to include the new function name.

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/1975a2d7f60a
https://hg.mozilla.org/integration/autoland/rev/ee8f95160b26
Implement CSS contrast-color() function. r=firefox-style-system-reviewers,emilio,tlouw
https://github.com/mozilla-firefox/firefox/commit/650bf2228217
https://hg.mozilla.org/integration/autoland/rev/82b99fe4af59
Add a basic WPT reftest for results of the contrast-color() function. r=firefox-style-system-reviewers,emilio

Comment 17

[amarc]

https://hg.mozilla.org/mozilla-central/rev/ee8f95160b26
https://hg.mozilla.org/mozilla-central/rev/82b99fe4af59

Comment 18

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 19

[Dianna Smith [:diannaS]]

Added to 146 release notes https://www.firefox.com/en-US/firefox/146.0a1/releasenotes/

Comment 20

[Chris Mills [:cmills]]

See:

• https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/146#css
• https://developer.mozilla.org/en-US/docs/Web/CSS/Reference/Values/color_value/contrast-color#browser_compatibility