Closed Bug 1682471 Opened 5 years ago Closed 4 years ago

PIP video flickering with MOZ_X11_EGL=1

Categories

(Core :: Graphics: WebRender, defect, P3)

Product:
Core
Component:
Graphics: WebRender
Type:
defect

Tracking

()

Status:
RESOLVED WORKSFORME

People

(Reporter: sotaro, Unassigned)

References

(Blocks 1 open bug)

Details

When Firefox run with MOZ_X11_EGL=1, PIP video had flickering.

Blocks: egl-linux-vaapi
Component: Graphics: WebRender → Graphics
Component: Graphics → Graphics: WebRender

I saw the problem with the following STR.

  • [1] Start Firefox and set pref media.ffmpeg.vaapi.enabled=true and gfx.webrender.all=true
  • [2] Re-start Firefox with "MOZ_DISABLE_RDD_SANDBOX=1 MOZ_X11_EGL=1 ./mach run"
  • [3] Visit https://www.youtube.com/watch?v=LXb3EKWsInQ
  • [4] Set video to 1440p60
  • [5] Enable PIP

At [5], PIP video rendering had flickering. The problem seemed to happen when video resolution was high.

MOZ_DISABLE_RDD_SANDBOX=1 of [2] was necessary for Bug 1673184.

See Also: → 1673184

When MOZ_X11_EGL=1 , RenderCompositorOGL was used instead of RenderCompositorEGL. It seems to be related. RenderCompositorEGL uses shared GL context, but RenderCompositorOGL does not. It seems that RenderDMABUFTextureHost could not handle multiple GL contexts.

During PIP, video frames are forwarded to both main window and PIP window. See Bug 1682206

See Also: → 1682206

cc Andrew: I can't recall what the current status was regarding making EGL the default.

Blocks: wr-linux
Severity: -- → S3
Priority: -- → P3

(In reply to Jamie Nicol [:jnicol] from comment #3)

cc Andrew: I can't recall what the current status was regarding making EGL the default.

Sounds like something we should fix first. It would only go out to nightly first anyways.

Is there a metabug for that which we should block this against?

No longer blocks: wr-linux

Sotaro, was this fixed by bug 1684194?

Flags: needinfo?(sotaro.ikeda.g)

(In reply to Sotaro Ikeda [:sotaro] from comment #1)

I saw the problem with the following STR.

  • [1] Start Firefox and set pref media.ffmpeg.vaapi.enabled=true and gfx.webrender.all=true
  • [2] Re-start Firefox with "MOZ_DISABLE_RDD_SANDBOX=1 MOZ_X11_EGL=1 ./mach run"
  • [3] Visit https://www.youtube.com/watch?v=LXb3EKWsInQ
  • [4] Set video to 1440p60
  • [5] Enable PIP

At [5], PIP video rendering had flickering. The problem seemed to happen when video resolution was high.

MOZ_DISABLE_RDD_SANDBOX=1 of [2] was necessary for Bug 1673184.

Sorry, for slow response.
Since Bug 1685436 fix, pref media.rdd-process.enabled=false was necessary for testing. And I confirmed that the problem was addressed.

Status: NEW → RESOLVED
Closed: 4 years ago
Flags: needinfo?(sotaro.ikeda.g)
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.