1682497 - Integers not accepted in print range ranges

Status: RESOLVED FIXED

(Testing :: geckodriver, defect, P2)

Description

[James Graham [:jgraham]]

Per the spec we should be able to define page ranges as ["1-2", 4, "6-" ] using a mixture of integers and strings. But the WebDriver crate defines the relevant type as Vec<String>. This should probably be changed to:

enum PageRange {
  SinglePage(u64),
  Range(String)
}

[...]
page_ranges: Vec<PageRange>

with the necessary annotations so serde picks the variant based on the type.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

This is blocking a P2 bug so it should be P2 as well.

Comment 2

[Mitesh]

Hi, I would like work on it.

Comment 3

[Mitesh]

Attachment: Bug 1682497 - [geckodriver] Added Page Range for Integers

Comment 4

[Mitesh]

Attachment: Bug 1682497 - Used PrintPageRange instead of vector.

Depends on D182624

Comment 5

[Mitesh]

Attachment: Bug 1682497 - [wdspec] Updated WebDriver classic print tests for integer value in page range

Depends on D182624

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b713d85d3c3a
[geckodriver] Added Page Range for Integers r=webdriver-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/f23fa8420e5a
[wdspec] Updated WebDriver classic print tests for integer value in page range r=webdriver-reviewers,whimboo

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/41553 for changes under testing/web-platform/tests

Comment 8

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/b713d85d3c3a
https://hg.mozilla.org/mozilla-central/rev/f23fa8420e5a

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot