1682511 - Record the WER runtime exception module in the Windows registry

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, task)

Description

[Gabriele Svelto [:gsvelto]]

Once the WER runtime exception module is ready we'll need to record its location in the Windows registry. Specifically the full path to the module's DLL needs to be recorded under
HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\Windows Error Reporting\RuntimeExceptionHelperModules on native 32/64-bit Windows or under HKEY_LOCAL_MACHINE\SOFTWARE\Wow6432Node\Microsoft\Windows\Windows Error Reporting\ 32-bit apps running under 64-bit Windows

Since this will be rolled out with updates we need to make sure that this is also done while updating and not just upon the first installation.

Comment 1

[Gabriele Svelto [:gsvelto]]

The registry entry must be a DWORD with data set to 0x00000000 and the name containing the module's full path.

Comment 2

[Gabriele Svelto [:gsvelto]]

Attachment: Bug 1682511 - Add the WER module to the installer and record its path in the Windows registry r=mhowell

Comment 3

[Gabriele Svelto [:gsvelto]]

Molly I need some help hacking the Windows installer. I need to write a registry key upon installation (and upon upgrade too). It will point to the newly installed Windows Error Reporting module DLL as per comment 0. Ideally this key should also be deleted when uninstalling.

My NSIS-fu is a bit rusty so scouring our installer files I kind-of figured that adding the key should happen somewhere in here but I should also do it in PostUpdate. I'm also not sure where removing the key during uninstallation should go, maybe here? Does this make sense or am I on the wrong track?

Comment 4

[Molly Howell (she/her) (mostly inactive)]

You're definitely on the right track. Just as a matter of organization, I'd suggest putting this next to where the accessibility DLL registrations are handled, so here in the installer, here in PostUpdate, and here in the uninstaller. I was also going to mention PushFilesToCheck, but I see you've already got that handled, so I think that should do it.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/caab7d97ad51
Add the WER module to the installer and record its path in the Windows registry r=mhowell

Comment 6

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/caab7d97ad51