1682551 - Prevent non-reviewers from updating non-english KB description and slug

Status: RESOLVED FIXED

(support.mozilla.org :: Knowledge Base Software, task)

Description

[Kelimutu [:kiki]]

Attachment: Screenshot_2020-12-15 Terjemahkan Artikel Add-on Badges Dukungan Mozilla.png

I've seen enough examples of non-contributors modified kb description (title and slug) with wrong detail (sometimes even using an obscene term). Article revision should be approved before being published, but article description can still be modified by any user. This is not ideal.

This time, it's an add-ons article that is changed to 'youtube' as the title.
Original article: https://support.mozilla.org/en-US/kb/add-on-badges/history
False localized/modified version: https://support.mozilla.org/id/kb/youtube

I'll change the title back to English since we don't have the correct localization for the article yet.

Comment 1

[Kelimutu [:kiki]]

Attachment: Screenshot_2020-12-15 Riwayat Revisi youtube Dukungan Mozilla.png

The same person is trying to modify the content (which, hasn't been translated at all). https://support.mozilla.org/id/kb/youtube/review/209904

Comment 2

[Kelimutu [:kiki]]

Attachment: Screenshot_2020-12-15 icupertamina Profil Dukungan Mozilla.png

Screenshot of the user profile

https://support.mozilla.org/id/user/icupertamina

Comment 3

[Abby Parise]

Hi Kiki, was this request ever resolved? Just cleaning out the Bugzilla queue today!

Comment 4

[Leo McArdle [:leo]]

This is still a problem, but one of the KB software (and policy/programmatic decisions) rather than content.

Related github issue: https://github.com/mozilla/sumo/issues/566

Comment 6

[Kelimutu [:kiki]]

I forgot I filed this one and opened another report (bug 1756475) yesterday. I'll just reiterate my proposal here to make it easier to discuss.

My proposal would be to treat changes to article's title and slug as revision. So, adding an extra layer of verification process before the changes are applied.

From a quick convo with Alice in bug 1756475, it seems that this issue only happen on the non-english locales. On English KB, only reviewer are able to change title and slug.

Another proposal that might be possible is to treat an already localized non-English KB the same as the English one, so only reviewers are able to modify the tittle and slug. The problem remains with how we should treat a fresh localized article with random term. Because as far as I know (and I just tested it), the changes to title and slug are made immediately once the new revision is sent. Which is a problem if the slug contain spammy content from random spammer.

Comment 7

[Kelimutu [:kiki]]

Just wanted to let you all know that this is underway. Ryan ended up restrict KB articles (including the localized one) with no approved content for a few groups, including the creator, superusers, and users with special permission (admin, KB reviewers, Reviewers, locale leaders, locale reviewers, and users with wiki.review_revision and/or wiki.delete_document permission).

Here's the related PR: https://github.com/mozilla/kitsune/pull/5181

Comment 8

[Tasos Katsoulas [:tasos]]

A fix for this has been released to prod.

Comment 9

[Alice Wyman]

(In reply to Kelimutu [:kiki] from comment #7)

Just wanted to let you all know that this is underway. Ryan ended up restrict KB articles (including the localized one) with no approved content for a few groups, including the creator, superusers, and users with special permission (admin, KB reviewers, Reviewers, locale leaders, locale reviewers, and users with wiki.review_revision and/or wiki.delete_document permission).

Here's the related PR: https://github.com/mozilla/kitsune/pull/5181

Users who are not signed in to Mozilla Support and signed in users with no special permission will now see a Page Not Found (404) page when they visit an article with no approved content (screenshot).. This can be an issue for in-product links when content is pending review or when the linked article is only a placeholder, as reported in bug 1786702 (quote: The opened page, https://support.mozilla.org/en-US/kb/quick-actions-firefox-search-bar?as=u&utm_source=inproduct, is a 404).