Closed Bug 1682602 Opened 9 months ago Closed 7 months ago

Remove pinning and drag & drop support for sponsored top sites

Categories

(Firefox :: Top Sites, defect, P2)

defect
Points:
2

Tracking

()

VERIFIED FIXED
88 Branch
Iteration:
87.2 - Feb 8 - Feb 21
Tracking Status
firefox88 --- verified

People

(Reporter: dao, Assigned: amy)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Following up from bug 1681757, pinning sponsored top sites loses their Sponsored label and won't send the attribution request. This is a weird state to be in, so at this point I think we should remove pinning and drag & drop support for sponsored top sites.

Blocks: 1690584
No longer blocks: 1653929
Assignee: nobody → achurchwell
Status: NEW → ASSIGNED
Iteration: --- → 87.2 - Feb 8 - Feb 21
Summary: Consider removing pinning and drag & drop support for sponsored top sites → Remove pinning and drag & drop support for sponsored top sites
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/746b44ef2373
remove pinning and drag/drop support for sponsored top sites. r=dao

Backed out changeset 746b44ef2373 (Bug 1682602) for causing node newtab failures.

Backout link: https://hg.mozilla.org/integration/autoland/rev/b7099ca60ba9d82b4ff75db50fcc104fc77ab224
Push with failures, Failure log

Flags: needinfo?(achurchwell)
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c67c29d89bd4
remove pinning and drag/drop support for sponsored top sites. r=dao
Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
Flags: needinfo?(achurchwell)

We verified using the experiment configuration that the Sponsored Top Sites can now no longer be moved (not dragged nor dropped) from their positions and they no longer have the Pin option in their context menu. Tested using Firefox Nightly 88.0a1 (Build ID: 20210310093927) on Windows 10, Linux Mint 20 and macOS 10.15.7.

If the Sponsored Top Site has already been pinned/moved in a previous Firefox version (e.g. 87), when the browser is updated to version 88 the Sponsored Top Sites are still displayed in their pinned positions. If the user unpins them they become Sponsored Top Sites again and they can no longer be moved or pinned. :dao, could you please confirm whether this is the expected behavior?

Preferences used:
browser.search.experiment set to amazondotcom-adm (for US region)
browser.topsites.experiment.ebay-2020-1 set to true
browser.partnerlink.useAttributionURL set to true
browser.topsites.useRemoteSetting set to true
browser.search.region set to US or FR

Flags: needinfo?(dao+bmo)

Yes, that's expected. Thanks.

Flags: needinfo?(dao+bmo)

Based on the previous comments I will mark this as verified fixed.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.