1682602 - Remove pinning and drag & drop support for sponsored top sites

Status: VERIFIED FIXED

(Firefox :: Top Sites, defect, P2)

Description

[Dão Gottwald [:dao]]

Following up from bug 1681757, pinning sponsored top sites loses their Sponsored label and won't send the attribution request. This is a weird state to be in, so at this point I think we should remove pinning and drag & drop support for sponsored top sites.

Comment 1

[Amy Churchwell [:amy]]

Attachment: Bug 1682602 - remove pinning and drag/drop support for sponsored top sites. r?dao

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/746b44ef2373
remove pinning and drag/drop support for sponsored top sites. r=dao

Comment 3

[Alexandru Michis [:malexandru]]

Backed out changeset 746b44ef2373 (Bug 1682602) for causing node newtab failures.

Backout link: https://hg.mozilla.org/integration/autoland/rev/b7099ca60ba9d82b4ff75db50fcc104fc77ab224
Push with failures, Failure log

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c67c29d89bd4
remove pinning and drag/drop support for sponsored top sites. r=dao

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/c67c29d89bd4

Comment 6

[Maria Heres, inactive, contact Ecosystem QA]

We verified using the experiment configuration that the Sponsored Top Sites can now no longer be moved (not dragged nor dropped) from their positions and they no longer have the Pin option in their context menu. Tested using Firefox Nightly 88.0a1 (Build ID: 20210310093927) on Windows 10, Linux Mint 20 and macOS 10.15.7.

If the Sponsored Top Site has already been pinned/moved in a previous Firefox version (e.g. 87), when the browser is updated to version 88 the Sponsored Top Sites are still displayed in their pinned positions. If the user unpins them they become Sponsored Top Sites again and they can no longer be moved or pinned. :dao, could you please confirm whether this is the expected behavior?

Preferences used:
browser.search.experiment set to amazondotcom-adm (for US region)
browser.topsites.experiment.ebay-2020-1 set to true
browser.partnerlink.useAttributionURL set to true
browser.topsites.useRemoteSetting set to true
browser.search.region set to US or FR

Comment 7

[Dão Gottwald [:dao]]

Yes, that's expected. Thanks.

Comment 8

[Maria Heres, inactive, contact Ecosystem QA]

Based on the previous comments I will mark this as verified fixed.