1682623 - Enable Warp Compiled Generators and Async Functions

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, enhancement, P2)

Description

[Matthew Gaudet (he/him) [:mgaudet]]

Bugs 1680602 and 1681336 implement warp compiled async and generator functions. However, they are landing disabled to reduce risk over the holiday season and to allow some time for tuning and performance investigation as required.

This bug is for enabling them by default.

Comment 1

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1682623 - Enable Warp compiling generators and async functions by default r?iain

We seem to have not had a further influx of fuzzing issues on this feature,
and my measurements of performance have shown no notable degradations (and a
few benchmark benefits), so I think it's time to let this ride the trains.

If we do this shortly, we'll have a few weeks of coverage on nightly before
soft freeze.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8924f5fc3c4b
Enable Warp compiling generators and async functions by default r=iain

Comment 3

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/8924f5fc3c4b

Comment 4

[Florin Strugariu [:Bebe]]

== Change summary for alert #28446 (as of Fri, 15 Jan 2021 06:05:19 GMT) ==

Improvements:

Ratio	Suite	Test	Platform	Options	Absolute values (old vs new)
4%	raptor-ares6-firefox		linux64-shippable	nocondprof	53.27 -> 51.02
3%	raptor-ares6-firefox		linux64-shippable	nocondprof	53.29 -> 51.65

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=28446

Comment 5

[Alexandru Ionescu (needinfo me) [:alexandrui]]

== Change summary for alert #28511 (as of Thu, 21 Jan 2021 19:48:26 GMT) ==

Improvements:

Ratio	Suite	Test	Platform	Options	Absolute values (old vs new)
4%	ares6-sm		linux64-shippable		49.91 -> 47.80

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=28511