1682636 - Don't let blocklist rules that apply to all features, apply to WebRender Software

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, task, P3)

Description

[Andrew Osmond [:aosmond] (he/him)]

A blocklist rule could block all features. This shouldn't apply to WebRender Software because it is our Basic replacement. Basic can never be blocked since it is what we use when one cannot use hardware acceleration.

Comment 1

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 1682636 - Don't allow generic blocklist rules to block SW-WR.

Since Software WebRender is the replacement for Basic compositor, we
should not allow generic blocklist rules which block all features to
block Software WebRender. This feature must work under all
configurations, including safe mode, so it doesn't make sense to allow
blocking it.

This does not however prevent rules specifically targeting SW-WR from
blocking/allowing it.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/12545700455b
Don't allow generic blocklist rules to block SW-WR. r=jrmuizel

Comment 3

[Dorel Luca [:dluca]]

Backed out changeset 12545700455b (bug 1682636) for Wd failures. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer?job_id=324622470&repo=autoland&lineNumber=66124

Backout:
https://hg.mozilla.org/integration/autoland/rev/10e8faf4ab79cdf8c05b13e2f6c9ed933b4f330e

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0f91e8933a62
Don't allow generic blocklist rules to block SW-WR. r=jrmuizel

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/0f91e8933a62