1682660 - build-compiler-rt isn't using the right target for some files

Status: RESOLVED FIXED

(Firefox Build System :: Toolchains, defect)

Description

[(Away)]

The cflags are getting through to some files, but not others. In the compilations that don't receive a mac -target, clang doesn't know what to do with -mmacosx-version-min :

[task 2020-12-07T05:25:40.349Z] [203/684] Building C object lib/builtins/CMakeFiles/clang_rt.builtins_arm64_osx.dir/fixtfsi.c.o
[task 2020-12-07T05:25:40.350Z] clang: warning: argument unused during compilation: '-arch arm64' [-Wunused-command-line-argument]
[task 2020-12-07T05:25:40.351Z] clang: warning: argument unused during compilation: '-mmacosx-version-min=10.5' [-Wunused-command-line-argument]
[task 2020-12-07T05:25:40.351Z] clang: warning: argument unused during compilation: '-arch arm64' [-Wunused-command-line-argument]
[task 2020-12-07T05:25:40.351Z] [204/684] Building C object lib/builtins/CMakeFiles/clang_rt.builtins_arm64_osx.dir/fixtfti.c.o
[task 2020-12-07T05:25:40.359Z] clang: warning: argument unused during compilation: '-arch arm64' [-Wunused-command-line-argument]
[task 2020-12-07T05:25:40.359Z] clang: warning: argument unused during compilation: '-mmacosx-version-min=10.5' [-Wunused-command-line-argument]
[task 2020-12-07T05:25:40.359Z] clang: warning: argument unused during compilation: '-arch arm64' [-Wunused-command-line-argument]
[task 2020-12-07T05:25:40.359Z] [205/684] Building C object lib/builtins/CMakeFiles/clang_rt.builtins_arm64_osx.dir/fixunstfdi.c.o
[task 2020-12-07T05:25:40.360Z] clang: warning: argument unused during compilation: '-arch arm64' [-Wunused-command-line-argument]
[task 2020-12-07T05:25:40.360Z] clang: warning: argument unused during compilation: '-mmacosx-version-min=10.5' [-Wunused-command-line-argument]
[task 2020-12-07T05:25:40.360Z] clang: warning: argument unused during compilation: '-arch arm64' [-Wunused-command-line-argument]
[task 2020-12-07T05:25:40.360Z] [206/684] Building C object lib/builtins/CMakeFiles/clang_rt.builtins_arm64_osx.dir/fixunstfsi.c.o

Comment 1

[(Away)]

Attachment: Bug 1682660 - Wrap clang to pass all the necessary flags when building compiler-rt.

For reasons that I haven't been able to figure out, some compilations aren't getting the -target flag passed to them from the cmake flags. This patch forces the target by using a prefixed tool name.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1682660 - Set CMAKE_RANLIB when building compiler-rt.

Without it, the build uses /usr/bin/ranlib, which, for some reason,
doesn't fail, but does weird things.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/61081ada2d26
Wrap clang to pass all the necessary flags when building compiler-rt. r=dmajor
https://hg.mozilla.org/integration/autoland/rev/fadedbba0655
Set CMAKE_RANLIB when building compiler-rt. r=dmajor

Comment 4

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/61081ada2d26
https://hg.mozilla.org/mozilla-central/rev/fadedbba0655