1682821 - Fix content blocking milestone message test and trigger

Status: RESOLVED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Andrei Oprea [:andreio]]

The test for this message would trigger a different message template and the actual Milestone message was never properly tested. This allowed for some refactoring done in the past to break the message.

Comment 1

[Andrei Oprea [:andreio]]

Attachment: Bug 1682821 - Fix content blocking milestone message test and trigger

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/60e886fcc3db
Fix content blocking milestone message test and trigger r=nanj

Comment 3

[Atila Butkovits]

Backed out for causing failures on browser_asrouter_trigger_listeners.js.

Backout link: https://hg.mozilla.org/integration/autoland/rev/5240e7d7fd57d096fd01b536573e906cde082bd4

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&searchStr=linux%2C18.04%2Cx64%2Ctsan%2Copt%2Cmochitests%2Ctest-linux1804-64-tsan%2Fopt-mochitest-browser-chrome-e10s%2Cbc20&revision=60e886fcc3db9f0ed4e173732653ef00ccead3c3&selectedTaskRun=N8CWd1lhQXeXHcFm3ctnYQ.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=324836697&repo=autoland&lineNumber=2854

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a63c06574534
Fix content blocking milestone message test and trigger r=nanj

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/a63c06574534