1682866 - Alert sticks around after you navigate away from the page

Status: RESOLVED FIXED

(Toolkit Graveyard :: Notifications and Alerts, defect)

Description

[B.J. Herbison]

Attachment: alertAndRun.html

Steps to reproduce:

1. Load the attached file.
2. Type "https://www.foxnews.com/" in the URL bar and press enter.

Expected:
2) No more alert.

Actual:
2) The alert is still present on the new page.

Comment 1

[B.J. Herbison]

Attachment: Screenshot from 2020-12-16 10-11-34.png

Comment 2

[Kestrel]

Only happens for me with fission.autostart = true. The alert is not permanent and goes away when the page has finished loading and the focus switches from the location bar to the page content.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=2639768bd77f2b1fe89f62a5a286153cd922639c&tochange=778e524a9f31eb873be112dab17b8b272ba56dde

Regressed by Bug 1662265.

Comment 4

[Sean Feng [:sefeng]]

I'll fix it, thanks for the report!

Comment 5

[Sean Feng [:sefeng]]

Attachment: Bug 1682866 - Force enable InputTaskManager when we about to destroy the process

Comment 6

[Sean Feng [:sefeng]]

Attachment: Bug 1682866 - Always use normal priority for DelayedDeleteRunnable

DelayedDeleteRunnable would schedule itself twice and use input priority
for the second time because it only wants to run after everything
that could possibly touch this tab. This was needed because we were
strict with IPC messages. However, this is no longer needed because
IPC messages with destroyed actors will be discarded nowadays, so
we don't have to use input priority anymore.

Another reason for making this change is that input events could be
suspended when the runnable is about to run, so we need to either
use a different priority or resume input events.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4f64228de0b3
Always use normal priority for DelayedDeleteRunnable r=smaug

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/4f64228de0b3

Comment 9

[Sean Feng [:sefeng]]

This is now fixed.