1682943 - Replace idl nsISimpleEnumerator usage with Array<T> in mailnews/compose

Status: RESOLVED FIXED

(MailNews Core :: General, task)

Description

[Ben Campbell]

Replacing nsISimpleEnumerator with Array<> (where sensible!)

This covers:
mailnews/compose/public/nsIMsgCompFields.idl
mailnews/compose/public/nsISmtpService.idl

Comment 1

[Ben Campbell]

Attachment: 1682943-remove-nsISimpleEnumerator-in-nsISmtpService-1.patch

Comment 2

[Ben Campbell]

Attachment: 1682943-remove-nsISimpleEnumerator-in-nsIMsgCompFields-1.patch

Comment 3

[Ben Campbell]

Those two are reasonably straightforward. The biggest (most annoying) changes are indentation.
https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=46d8f3ab36fca76ad9befcde9f3297f3a71030dd

Comment 4

[Magnus Melin [:mkmelin] (away until Aug 10)]

Comment on attachment 9193782 [details] [diff] [review]
1682943-remove-nsISimpleEnumerator-in-nsIMsgCompFields-1.patch

Review of attachment 9193782 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/components/compose/content/MsgComposeCommands.js
@@ +5857,3 @@
>   *
> + * @param {nsIMsgAttachment[]} aAttachments - Objects to add as attachments.
> + * @param {function} aCallback - An optional callback function called after

Document that it's optional using brackets like this:

@param {function} [aCallback] -

@@ +5859,5 @@
> + * @param {function} aCallback - An optional callback function called after
> + *   adding each attachment. Takes one argument: the newly-added
> + *   <attachmentitem> node.
> + * @param {Boolean} aContentChanged - Optional value to assign gContentChanged
> + *   after adding attachments; defaults to true.

And with a default value like this:

@param {Boolean} [aContentChanged=true]

Comment 5

[Ben Campbell]

Attachment: 1682943-remove-nsISimpleEnumerator-in-nsIMsgCompFields-2.patch

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/ebdbcdfcf130
Remove nsISimpleEnumerator use in nsISmtpService.idl. r=mkmelin
https://hg.mozilla.org/comm-central/rev/a871e4f02dac
Remove nsISimpleEnumerator use in nsIMsgCompFields.idl. r=mkmelin