1682980 - Glinter should lint on metric categories, metric names, labels, reasons, and ping names being "too short"

Status: RESOLVED WONTFIX

(Data Platform and Tools :: Glean: SDK, defect, P1)

Description

[Chris H-C :chutten]

I was thinking maybe Glinter should complain if your strings are too short.

Here's some WAGs to get us started:

• Metric Category: Min length 2 (I can definitely think of one of length three (gfx), so 2 might be sensible)
• Metric Names: Min length 3 (English has the meaningful word now of length 3, so we shouldn't forbid it)
• Labels: Min length 2 (Again, I can think of length three (sun, eOK))
• Reasons: Min length 2 (similar reasons)
• Ping names: Min length 3 (check with ingestion if there's limits on their side)

Thoughts?

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/glean_parser/pull/267

Comment 2

[Michael Droettboom [:mdroettboom]]

Given that the PR ended in a discussion about some legitimate uses for 2-character names (os), I'm inclined to think this is more trouble than worth and WONTFIX. But also could be persuaded otherwise...

Comment 3

[Chris H-C :chutten]

Sure. We can always open another of these later if we find negative examples we want to prevent. (maybe category.name should be a combined minimum of six, and we can get really opinionated about ping names).