1682982 - [REGRESSION] The local storage editor is not updating after page reload

Status: RESOLVED DUPLICATE of bug 1685474

(DevTools :: Storage Inspector, defect, P2)

Description

[Dariusz Czajkowski]

Attachment: index.html

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:84.0) Gecko/20100101 Firefox/84.0

Steps to reproduce:

On the 4th of December, 2020, I have noticed (sorry for waiting so long to report) a bug in the local storage editor inside Firefox for Developers. It can be reproduced on Nightly as of 16th of December, 2020.

This is definitely a regression, probably introduced around November/beginning of December.

Please see the demo: https://streamable.com/fbswc7

Steps to reproduce:

1. Open attached index.html on localhost
2. Open devtools and click the 'add' button (it adds a simple entry to LS)
3. The devtools should correctly show added items
4. Refresh the page
5. Click the 'add' button

Actual results:

The devtools are not showing newly added entries. Moreover, clicking on the "refresh" button inside the LS completely hides all LS entries.

Expected results:

I would expect devtools to reflect the current state of LS.

Comment 1

[Dariusz Czajkowski]

This is what appears in the console, when the bug occurs (on Trunk). One of the cases is when clicking the refresh button:

console.error: "Error while calling actor 'localStorage's method 'getStoreObjects'" "can't access dead object"
console.error: "getValuesForHost@resource://devtools/server/actors/storage.js:1264:23\ngetStoreObjects@resource://devtools/server/actors/storage.js:428:30\nhandler@resource://devtools/shared/protocol/Actor.js:172:37\nonPacket@resource://devtools/server/devtools-server-connection.js:379:58\nreceiveMessage@resource://devtools/shared/transport/child-transport.js:68:16\n"
console.error: (new Error("Protocol error (TypeError): can't access dead object from: server0.conn1.child3/localStorage27 (resource://devtools/server/actors/storage.js:1264:23)", "resource://devtools/shared/protocol/Front.js", 361))

Comment 2

[Dariusz Czajkowski]

After some testing, here are Firefox stable versions and what is their behavior:

• 82.0 - everything works as expected
• 83.0 - after the page refresh (step 4), clicking the button (step 5) does not update the list, but clicking on the refresh LS table button works
• 84.0 - same as above, but clicking on the refresh LS table button does not work (same behavior as Trunk)

Comment 3

[Dariusz Czajkowski]

Following a suggestion of :ladybenko, I am leaving a comment to let a reader know, this is a possible duplicate of 1679725

Comment 4

[Chris Peterson [:cpeterson]]

Tracking dt-fission-m3-mvp bugs for Fission M8 (blocking Release channel experiment, but not Beta experiment).

Comment 5

[Julian Descottes [:jdescottes]]

Isn't this a dupe of Bug 1685474 which is about navigation issues in the storage panel?

Comment 6

[Chris Peterson [:cpeterson]]

Moving dt-fission-m3-mvp bugs from Fission M8 to M7 (blocking Beta experiment).

Comment 7

[Belén [:ladybenko]]

Adding is as duplicate, since the patch being worked on 1685474 seems to fix this issue.