Closed Bug 1683065 Opened 5 years ago Closed 5 years ago

On gnome, remote dark theme is not applied correctly

Categories

(Core :: Widget: Gtk, defect)

x86_64
Linux
defect

Tracking

()

RESOLVED WORKSFORME
Tracking Status
firefox-esr78 --- unaffected
firefox84 --- unaffected
firefox85 --- unaffected
firefox86 --- affected

People

(Reporter: kubrick, Unassigned)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Website such as whatsapp, youtube or bugzilla don't use the dark theme when set at the system level any more since that revision:

GDK_BACKEND=wayland mozregression --repo autoland --pref gfx.webrender.enabled:true --pref media.rdd-process.enabled:false --pref security.sandbox.content.level:0 -g 2020-11-16 --persist /tmp/ -g 2020-12-16

Mozregression range:
2:49.54 INFO: Last good revision: 26bbc0bbde6939815823c299365fb6a6a8fb3da3
2:49.54 INFO: First bad revision: 12f20df84a54b6d59b35babad06e57dd7ab3417e
2:49.54 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=26bbc0bbde6939815823c299365fb6a6a8fb3da3&tochange=12f20df84a54b6d59b35babad06e57dd7ab3417e

Has Regression Range: --- → yes
Regressed by: 1672097

Acutally, the dark theme is also applied to some elements, like input fields, when they should not (see attached)

Summary: On gnome, remote dark theme is not used any more → On gnome, remote dark theme is not applied correctly

The text fields are dark when they shouldn't, text is unreadable.

Set release status flags based on info from the regressing bug 1672097

Flags: needinfo?(cam)

Comment 0 is bug 1683026.
I don't know about comment 1.

Bug fixed as of 21/12/2020

Status: UNCONFIRMED → RESOLVED
Closed: 5 years ago
Resolution: --- → WORKSFORME

The comment 1 issues were fixed by preffing off the RemoteLookAndFeel in bug 1683204. (Which also has a patch for the issue and to turn it back on.)

Flags: needinfo?(cam)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: