1683120 - vsynctester.com becomes very slow with remote canvas and d3d11 (not advanced) after switching tabs

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

It goes down to 12fps and doesn't come back up.

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Here's a profile: https://share.firefox.dev/2Wqepcw

Comment 2

[Jeff Muizelaar [:jrmuizel]]

I don't see this in 84. I'll get a regression window.

Comment 3

[Jeff Muizelaar [:jrmuizel]]

I didn't get a regression window but it looks like this was caused by disabling advanced layers.

Comment 4

[Jeff Muizelaar [:jrmuizel]]

Comment 5

[Jeff Muizelaar [:jrmuizel]]

Note, there are users running non-advanced d3d11 layers on release so this is still worth worrying about.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1679577

Comment 7

[Julien Cristau [:jcristau]]

Does that mean we should turn AL back on for 85?

Comment 8

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1683120 - Ensure that we always read unlock textures with LayerManagerComposite, even if there was no work to do. r?sotaro

Comment 9

[Bob Owen (:bobowen)]

(In reply to Julien Cristau [:jcristau] from comment #7)

Does that mean we should turn AL back on for 85?

No, with remote canvas disabled this bug is not such a big problem.
Although it still means we're hanging on to textures we shouldn't be, they only cause this issue with remote canvas enabled.

Comment 10

[Bob Owen (:bobowen)]

Hi both - are we going to be able to move this forward soon?
I really want to get this landed in 86, so I can re-enable remote canvas to ride the trains.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f31f215bebd3
Ensure that we always read unlock textures with LayerManagerComposite, even if there was no work to do. r=sotaro

Comment 12

[Bob Owen (:bobowen)]

Thanks both. :-)

Comment 13

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/f31f215bebd3

Comment 14

[Florin Strugariu [:Bebe]]

== Change summary for alert #28494 (as of Tue, 19 Jan 2021 19:38:58 GMT) ==

Improvements:

Ratio	Suite	Test	Platform	Options	Absolute values (old vs new)
4%	raptor-motionmark-animometer-firefox		windows10-64-shippable	nocondprof	39.15 -> 40.77
3%	raptor-motionmark-htmlsuite-firefox		windows10-64-shippable	nocondprof	31.94 -> 32.94

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=28494