1683137 - Remove extra added space above the search bar/logo on newtab page

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P1)

Description

[:prathiksha]

Remove extra added space with newtab update 1 on top of search. It's pushing Pocket down.

Comment 1

[:prathiksha]

Attachment: Bug 1683137 - Remove extra added space above the search bar/logo on newtab page. r?ewright

Comment 2

[:prathiksha]

Attachment: Bug 1683137 - Remove extra added space above the search bar/logo on newtab page. r?ewright

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3d6c55082612
Remove extra added space above the search bar/logo on newtab page. r=ewright

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/3d6c55082612

Comment 5

[:prathiksha]

Comment on attachment 9193770 [details]
Bug 1683137 - Remove extra added space above the search bar/logo on newtab page. r?ewright

Beta/Release Uplift Approval Request

• User impact if declined: We plan to experiment changes related to and including this patch on a small group of users in 85. If declined, Pocket gets pushed down on the page and may influence user behavior and skew the experiment.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: 1. Set the browser.newtabpage.activity-stream.customizationMenu.enabled pref to true in "about:config".

2. Verify that the content on newtab page is positioned exactly as before i.e.
   a. Distance between the top of the search bar and the top of the screen remains same with or without the pref set to true.
   b. Newtab content (such as Topsites, Pocket and Recent activity (Highlights)) remain centered on the page.
   c. Verify the above two bits by also disabling Pocket and setting browser.newtabpage.activity-stream.logowordmark.alwaysVisible to true (this enables the logo on top of the search bar).

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Simple CSS change + it will only be enabled for a very small group of people as part of an experiment.
• String changes made/needed: None

Comment 6

[Robert Martin [:romartin], Ecosystem QA]

I have verified the following with the steps provided in comment 5 using Firefox Nightly 86.0a1 (Build ID: 20201221093813) on Windows 10 x64, macOS 10.15.6, and Ubuntu Linux 20.04 x64:

• With the browser.newtabpage.activity-stream.logowordmark.alwaysVisible pref set to false and the browser.newtabpage.activity-stream.customizationMenu.enabled pref set to true:
  • The distance between the top of the search bar and the top of the screen is the same as the distance with the browser.newtabpage.activity-stream.customizationMenu.enabled pref set to false.
  • The "Top Sites", "Recommended by Pocket", and "Recent activity (Highlights)" sections are centered.
• With the browser.newtabpage.activity-stream.logowordmark.alwaysVisible pref set to true and the browser.newtabpage.activity-stream.customizationMenu.enabled pref set to true:
  • The distance between the top of the search bar and the top of the screen is the same as the distance with the browser.newtabpage.activity-stream.customizationMenu.enabled pref set to false.
  • The "Top Sites", "Recommended by Pocket", and "Recent activity (Highlights)" sections are centered.
  • If the "Recommended by Pocket" section is disabled in the "about:preferences#home" page, the Firefox Logo is correctly displayed above the "Search" bar.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9193770 [details]
Bug 1683137 - Remove extra added space above the search bar/logo on newtab page. r?ewright

Approved for 85.0b5.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/3901e0416205bb694c133525de882128cc949999

Comment 9

[Robert Martin [:romartin], Ecosystem QA]

I have verified the following with the steps provided in comment 5 using Firefox Beta 85.0b5 (Build ID: 20210105185604) on Windows 10 x64, macOS 10.15.6, and Ubuntu Linux 20.04 x64:

• With the browser.newtabpage.activity-stream.logowordmark.alwaysVisible pref set to false and the browser.newtabpage.activity-stream.customizationMenu.enabled pref set to true:
  • The distance between the top of the search bar and the top of the screen is the same as the distance with the browser.newtabpage.activity-stream.customizationMenu.enabled pref set to false.
  • The "Top Sites", "Recommended by Pocket", and "Recent activity (Highlights)" sections are centered.
• With the browser.newtabpage.activity-stream.logowordmark.alwaysVisible pref set to true and the browser.newtabpage.activity-stream.customizationMenu.enabled pref set to true:
  • The distance between the top of the search bar and the top of the screen is the same as the distance with the browser.newtabpage.activity-stream.customizationMenu.enabled pref set to false.
  • The "Top Sites", "Recommended by Pocket", and "Recent activity (Highlights)" sections are centered.
  • If the "Recommended by Pocket" section is disabled in the "about:preferences#home" page, the Firefox Logo is correctly displayed above the "Search" bar.