Closed Bug 1683149 Opened 3 years ago Closed 3 years ago

Perma tier 2 tests/jit-test/jit-test/tests/gc/weak-marking-01.js | obj2,obj3 (code 3, args "--ion-eager --ion-offthread-compile=off --more-compartments") [0.4 s]

Categories

(Core :: JavaScript Engine, defect, P5)

Product:
Core
Component:
JavaScript Engine
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
86 Branch
Tracking Flags:
Tracking Status
firefox-esr78 --- unaffected
firefox84 --- unaffected
firefox85 --- unaffected
firefox86 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: jonco)

References

(Regression)

Details

(Keywords: intermittent-failure, regression, Whiteboard: [retriggered])

Attachments

(1 file)

Bug 1683149 - Fix Android test failure related to incremental GC state r?sfink
48 bytes, text/x-phabricator-request
Details | Review

Filed by: rmaries [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=324831197&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/EV3qqVlrTD67WjTA9_-eXQ/runs/0/artifacts/public/logs/live_backing.log

[task 2020-12-17T15:54:28.147Z] 15:54:21     INFO -  TEST-PASS | tests/jit-test/jit-test/tests/gc/str-atom-dedupe.js | Success (code 0, args "--no-blinterp --no-baseline --no-ion --more-compartments") [0.4 s]
[task 2020-12-17T15:54:28.147Z] 15:54:22     INFO -  TEST-PASS | tests/jit-test/jit-test/tests/gc/str-atom-dedupe.js | Success (code 0, args "--blinterp-eager") [0.4 s]
[task 2020-12-17T15:54:28.147Z] 15:54:22     INFO -  TEST-PASS | tests/jit-test/jit-test/tests/gc/weak-marking-01.js | Success (code 0, args "") [0.5 s]
[task 2020-12-17T15:54:28.147Z] 15:54:23     INFO -  obj2,obj3
[task 2020-12-17T15:54:28.147Z] 15:54:23     INFO -  /data/local/tmp/test_root/tests/tests/tests/gc/weak-marking-01.js:136:11 Error: Assertion failed: got 4, expected 5
[task 2020-12-17T15:54:28.148Z] 15:54:23     INFO -  Stack:
[task 2020-12-17T15:54:28.148Z] 15:54:23     INFO -    weakKeysRealloc@/data/local/tmp/test_root/tests/tests/tests/gc/weak-marking-01.js:136:11
[task 2020-12-17T15:54:28.148Z] 15:54:23     INFO -    @/data/local/tmp/test_root/tests/tests/tests/gc/weak-marking-01.js:139:1obj2,obj3
[task 2020-12-17T15:54:28.148Z] 15:54:23     INFO -  /data/local/tmp/test_root/tests/tests/tests/gc/weak-marking-01.js:136:11 Error: Assertion failed: got 4, expected 5
[task 2020-12-17T15:54:28.148Z] 15:54:23     INFO -  Stack:
[task 2020-12-17T15:54:28.148Z] 15:54:23     INFO -    weakKeysRealloc@/data/local/tmp/test_root/tests/tests/tests/gc/weak-marking-01.js:136:11
[task 2020-12-17T15:54:28.148Z] 15:54:23     INFO -    @/data/local/tmp/test_root/tests/tests/tests/gc/weak-marking-01.js:139:1Exit code: 3
[task 2020-12-17T15:54:28.148Z] 15:54:23     INFO -  FAIL - gc/weak-marking-01.js
[task 2020-12-17T15:54:28.148Z] 15:54:23  WARNING -  TEST-UNEXPECTED-FAIL | tests/jit-test/jit-test/tests/gc/weak-marking-01.js | obj2,obj3 (code 3, args "--ion-eager --ion-offthread-compile=off --more-compartments") [0.4 s]
[task 2020-12-17T15:54:28.148Z] 15:54:23     INFO -  INFO exit-status     : 3
[task 2020-12-17T15:54:28.148Z] 15:54:23     INFO -  INFO timed-out       : False
[task 2020-12-17T15:54:28.148Z] 15:54:23     INFO -  INFO stdout          > obj2,obj3
[task 2020-12-17T15:54:28.148Z] 15:54:23     INFO -  INFO stdout          > /data/local/tmp/test_root/tests/tests/tests/gc/weak-marking-01.js:136:11 Error: Assertion failed: got 4, expected 5
[task 2020-12-17T15:54:28.148Z] 15:54:23     INFO -  INFO stdout          > Stack:
[task 2020-12-17T15:54:28.148Z] 15:54:23     INFO -  INFO stdout          > weakKeysRealloc@/data/local/tmp/test_root/tests/tests/tests/gc/weak-marking-01.js:136:11
[task 2020-12-17T15:54:28.148Z] 15:54:23     INFO -  INFO stdout          > @/data/local/tmp/test_root/tests/tests/tests/gc/weak-marking-01.js:139:1
[task 2020-12-17T15:54:28.148Z] 15:54:23     INFO -  INFO stderr         2> obj2,obj3
[task 2020-12-17T15:54:28.148Z] 15:54:23     INFO -  INFO stderr         2> /data/local/tmp/test_root/tests/tests/tests/gc/weak-marking-01.js:136:11 Error: Assertion failed: got 4, expected 5
[task 2020-12-17T15:54:28.148Z] 15:54:23     INFO -  INFO stderr         2> Stack:
[task 2020-12-17T15:54:28.148Z] 15:54:23     INFO -  INFO stderr         2> weakKeysRealloc@/data/local/tmp/test_root/tests/tests/tests/gc/weak-marking-01.js:136:11
[task 2020-12-17T15:54:28.148Z] 15:54:23     INFO -  INFO stderr         2> @/data/local/tmp/test_root/tests/tests/tests/gc/weak-marking-01.js:139:1```
Assignee: nobody → jcoppeard
Regressed by: 1677765
Has Regression Range: --- → yes
Keywords: regression

Set release status flags based on info from the regressing bug 1677765

status-firefox84: --- → unaffected
status-firefox85: --- → unaffected
status-firefox86: --- → affected
status-firefox-esr78: --- → unaffected

This test has been failing on Android since the concurrent unmarking change
landed. I've updated this test in line with the other test changes in that
patch, so that when we trigger an incremental GC we wait for marking to start
before finishing the GC non-incrementally.

I'm not actually sure what the problem is with relation to weak map marking. Do
we do this differently in incremental GCs? I couldn't find anything that
changes.

Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/43486a64baad
Fix Android test failure related to incremental GC state r=sfink
Whiteboard: [retriggered]

https://hg.mozilla.org/mozilla-central/rev/43486a64baad

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox86: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 86 Branch
See Also: → 1683456
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: