1683276 - Move CompilationStencil.{moduleMetadata, asmJS} out of CompilationStencil

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Tooru Fujisawa [:arai]]

StencilModuleMetadata contains multiple vectors, and sizeof(StencilModuleMetadata) is 152.
bug 1681011 made moduleMetadata field Maybe so that the ctor/dtor cost is removed, but still it takes some space, especially in delazification vector, where the field isn't used.

if we can move moduleMetadata out of CompilationStencil, it will reduce the memory taken by delazification vector.

Comment 1

[Tooru Fujisawa [:arai]]

or perhaps we can add a new struct inside CompilationStencil that contains fields shared between initial and delazification, and use the new struct in delazification vector.

Comment 2

[Tooru Fujisawa [:arai]]

I'll add InitialSpecificCompilationStencil and move asmJS/moduleMetadata there.

Comment 3

[Tooru Fujisawa [:arai]]

New plan:

• Rename CompilationStencil to BaseCompilationStencil
• Rename CompilationInfoVector to CompilationStencilSet
• Rename CompilationInfo to CompilationStencil
• Make CompilationStencil a subclass of BaseCompilationStencil, so that stencil field becomes this
• Make CompilationStencilSet a subclass of CompilationStencil, so that initial field becomes this
• move asmJS, moduleMetadata, scriptExtra to CompilationStencil, so that they become initial-stencil-only field, and delazification array (BaseCompilationStencil array) becomes smaller

the actual patch stack uses a bit different order.

Comment 4

[Tooru Fujisawa [:arai]]

Attachment: Bug 1683276 - Part 1: Rename CompilationStencil to BaseCompilationStencil. r?tcampbell!

Comment 5

[Tooru Fujisawa [:arai]]

Attachment: Bug 1683276 - Part 2: Rename CompilationInfoVector to CompilationStencilSet. r?tcampbell!

Depends on D101573

Comment 6

[Tooru Fujisawa [:arai]]

Attachment: Bug 1683276 - Part 3: Make CompilationInfo a subclass of BaseCompilationStencil. r?tcampbell!

Depends on D101574

Comment 7

[Tooru Fujisawa [:arai]]

Attachment: Bug 1683276 - Part 4: Make CompilationStencilSet a subclass of CompilationInfo. r?tcampbell!

Depends on D101575

Comment 8

[Tooru Fujisawa [:arai]]

Attachment: Bug 1683276 - Part 5: Rename CompilationInfo to CompilationStencil. r?tcampbell!

Depends on D101576

Comment 9

[Tooru Fujisawa [:arai]]

Attachment: Bug 1683276 - Part 6: Move asmJS to CompilationStencil. r?tcampbell!

Depends on D101577

Comment 10

[Tooru Fujisawa [:arai]]

Attachment: Bug 1683276 - Part 7: Move moduleMetadata to CompilationStencil. r?tcampbell!

Depends on D101578

Comment 11

[Tooru Fujisawa [:arai]]

Attachment: Bug 1683276 - Part 8: Move scriptExtra to CompilationStencil. r?tcampbell!

Depends on D101579

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/de1ed4223c83
Part 1: Rename CompilationStencil to BaseCompilationStencil. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/bd5dc5388b5d
Part 2: Rename CompilationInfoVector to CompilationStencilSet. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/c7533b190c9d
Part 3: Make CompilationInfo a subclass of BaseCompilationStencil. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/2328d39800e3
Part 4: Make CompilationStencilSet a subclass of CompilationInfo. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/829094e9aee5
Part 5: Rename CompilationInfo to CompilationStencil. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/10f2977fc704
Part 6: Move asmJS to CompilationStencil. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/5bc769813a88
Part 7: Move moduleMetadata to CompilationStencil. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/316011629013
Part 8: Move scriptExtra to CompilationStencil. r=tcampbell

Comment 13

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/de1ed4223c83
https://hg.mozilla.org/mozilla-central/rev/bd5dc5388b5d
https://hg.mozilla.org/mozilla-central/rev/c7533b190c9d
https://hg.mozilla.org/mozilla-central/rev/2328d39800e3
https://hg.mozilla.org/mozilla-central/rev/829094e9aee5
https://hg.mozilla.org/mozilla-central/rev/10f2977fc704
https://hg.mozilla.org/mozilla-central/rev/5bc769813a88
https://hg.mozilla.org/mozilla-central/rev/316011629013