1683300 - [meta] High CPU load (40% - 100%) caused by the top extensions loading animation on https://code.visualstudio.com/docs/

Status: NEW

(Core :: Graphics: WebRender, defect, P3)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:86.0) Gecko/20100101 Firefox/86.0 ID:20201217214927

Having the page https://code.visualstudio.com/docs/?dv=osx open in the currently selected tab causes a permanent high CPU load (40 - 100%) of the MainThread.

This is actually a new regression and I can see this first with the Firefox 84 release. Using 83.0 the CPU load is around 7% only.

Let me run mozregression to find the causing change.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

The problem here is actually the loading animation under Top Extensions. As it looks like whatever should be displayed there does not finish loading, and causes this high CPU load. Disabling JavaScript for that domain via NoScript makes it go away.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

If you are not seeing this problem because the top extensions list will be loaded please just add the following node to the DOM:

<div class="loading"></div>

Doing the same in Safari I see no CPU load.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

With Firefox 78 the CPU load is only around 20% but still high. So not sure if that is a regression per se.

Steps:

1. Load https://code.visualstudio.com/docs/?dv=osx
2. Open devtools and run the following code in the console:

var main = document.getElementById("main");
var div = document.createElement("div");
div.className = "loading";
main.appendChild(div);

3. Scroll down until the load animation is visible.

Moving bug over to the Performance component for triaging.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Here a gecko profile with all threads and IPC messages enabled: https://share.firefox.dev/3h17cJo

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

As it looks like Emilio and Olli cannot see this on Linux. Markus, given that you are on MacOS do you have a chance to check? Thanks.

Comment 6

[Markus Stange [:mstange]]

I can reproduce this.

Comment 7

[Markus Stange [:mstange]]

Attachment: basic testcase - causes 40% CPU usage on my machine

Comment 8

[Markus Stange [:mstange]]

Attachment: animated loading SVG from https://code.visualstudio.com/assets/loading.svg

Comment 9

[Markus Stange [:mstange]]

Attachment: testcase with loading SVG

Comment 10

[Markus Stange [:mstange]]

Attachment: testcase with loading SVG - causes 70% CPU on my machine

Comment 11

[Markus Stange [:mstange]]

Instruments profile: https://drive.google.com/file/d/1K823Ql4Dv99Pm1Uf0CkQ_3M4UyADcCkU/view?usp=sharing

I'm planning to file bugs for the individual pieces I found in there, on Monday.

Comment 12

[Kim Moir [:kmoir] ET]

Markus: Could you please link the bugs that you mentioned in comment #11 and set a priority/severity for this bug?

Comment 13

[Markus Stange [:mstange]]

Actually I'll move this into the Graphics component, IIRC all the issues here were gfx issues.

I'll have to look at the profiles and testcases again to remember what I found.

Comment 14

[Daniel Holbert [:dholbert]]

Ticking needinfo to remind you to do that. :)

Comment 15

[Henrik Skupin [:whimboo][⌚️UTC+1]]

The one dependent bug has been fixed. Markus, did you already file the other ones but maybe missed to add the dependency?

Comment 16

[Markus Stange [:mstange]]

I still need to file them. It's on my list.

Comment 17

[Markus Stange [:mstange]]

I have now filed everything I could find. In order of priority, I think bug 1688086 was the most important (and is now fixed), bug 1690621 is the next most important, and then bug 1689215.