1683412 - Enhance SHOW_MIGRATION_WIZARD handler inside SpecialMessageActions to accept "source" param

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement)

Description

[Emily McMinn :emcminn]

MigrationUtils.showMigrationWizard can accept a string as a "source" parameter, to determine which browser to attempt to import from. Let's add this param to SHOW_MIGRATION_WIZARD handler in SpecialMessageActions, so that we can predetermine source during the onboarding flow.

Possible sources listed here

Comment 1

[Emily McMinn :emcminn]

Attachment: Bug 1683412 - Enhance SHOW_MIGRATION_WIZARD to handle source param; add tests for SHOW_MIGRATION_WIZARD

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d624d8fffc17
Enhance SHOW_MIGRATION_WIZARD to handle source param; add tests for SHOW_MIGRATION_WIZARD r=pdahiya

Comment 3

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/d624d8fffc17

Comment 4

[Emily McMinn :emcminn]

Comment on attachment 9194022 [details]
Bug 1683412 - Enhance SHOW_MIGRATION_WIZARD to handle source param; add tests for SHOW_MIGRATION_WIZARD

Beta/Release Uplift Approval Request

• User impact if declined: none; this change will enable us to run experiments that rely on Chrome attribution
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Open about:config

Set overrideContent pref with JSON from https://gist.github.com/punamdahiya/22b029e003072325de4440435c84d26d

Open about:welcome and click Start Setup

Click import, Import wizard should have 'Chrome' as default

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This change is not risky since the behaviour must currently be triggered through the about:welcome JSON override; only users enrolled in current experiments will see the change.
• String changes made/needed: none

Comment 5

[Julien Cristau [:jcristau]]

Comment on attachment 9194022 [details]
Bug 1683412 - Enhance SHOW_MIGRATION_WIZARD to handle source param; add tests for SHOW_MIGRATION_WIZARD

approved for 85.0b5

Comment 6

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/2bc242bb524a

Comment 7

[Robert Martin [:romartin], Ecosystem QA]

I have verified the following using the steps provided in comment 4 with Firefox Nightly 86.0a1 (Build ID: 202010105094403) on Windows 10 x64, macOS 10.15, and Ubuntu Linux 20.04 x64:

• The "Chrome" option is selected by default in the "Import" page from the "about:welcome" if there is a Chrome browser installed.
• The "Chrome" option is not displayed in the "Import" page from the "about:welcome" if there has never been a Chrome browser installed.

Comment 8

[Robert Martin [:romartin], Ecosystem QA]

I have verified the following using the steps provided in comment 4 with Firefox Beta 85.0b5 (Build ID: 20210105185604) on Windows 10 x64, macOS 10.15, and Ubuntu Linux 20.04 x64:

• The "Chrome" option is selected by default in the "Import" page from the "about:welcome" if there is a Chrome browser installed.
• The "Chrome" option is not displayed in the "Import" page from the "about:welcome" if there has never been a Chrome browser installed.