1683526 - Search on bunnings.com.au not working with Firefox Nightly in ETP strict mode

Status: VERIFIED FIXED

(Core :: Privacy: Anti-Tracking, defect, P3)

Description

[Albert Scheiner [:alberts]]

Steps:

1. Go to https://www.bunnings.com.au/ on an Android phone with FF Nightly
2. Search for something

Expected:
After the page request a search result gets displayed.

Actual:
The page got served again the same way as before.

Update:
The navigation (hamburger) doesn't open, too, and the "Locating nearby store... " feature is not working either.

Comment 1

[Tim Huang[:timhuang]]

We have blocked the richrelevance.com in the strict mode which leads to this issue.

Comment 2

[Raul Bucata]

The issue is still reproducible.

Tested with:

Browser / Version: Firefox Nightly 210217 (🦎87.0a1-20210217094559🦎)
Operating System: OnePlus 6 (Android 10) - 2280 ×1080 pixels, 19:9 ratio (~402 ppi density)

Comment 4

[:glob ✱]

The stack is:

Uncaught TypeError: e.addItemId is not a function
    B https://www.bunnings.com.au/assets/styleguide/v222.0.0.2800-release/responsive/bunnings/js/main.js:11
    O https://www.bunnings.com.au/assets/styleguide/v222.0.0.2800-release/responsive/bunnings/js/main.js:11
    M https://www.bunnings.com.au/assets/styleguide/v222.0.0.2800-release/responsive/bunnings/js/main.js:11
    r https://www.bunnings.com.au/assets/styleguide/v222.0.0.2800-release/responsive/bunnings/js/main.js:13
    <anonymous> https://www.bunnings.com.au/assets/styleguide/v222.0.0.2800-release/responsive/bunnings/js/main.js:13
    <anonymous> https://www.bunnings.com.au/assets/styleguide/v222.0.0.2800-release/responsive/bunnings/js/main.js:13
    <anonymous> https://www.bunnings.com.au/assets/styleguide/v222.0.0.2800-release/responsive/bunnings/js/main.js:13

The shim (https://searchfox.org/mozilla-central/source/browser/extensions/webcompat/shims/rich-relevance.js) needs to noop addItemId, and possibly more.

Comment 5

[:glob ✱]

This impacts desktop and Android.

Comment 6

[:glob ✱]

Attachment: Bug 1683526 - Add more features to the richrelevance ETP shim; r=#webcompat-reviewers

Adds missing items from https://help.richrelevance.com/Integration_Guide/HTML_Integration%3A_Core_Integration/0022_HTML_Integration%3A_Search_Page

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7fb3b05f2570
Add more features to the richrelevance ETP shim; r=webcompat-reviewers,twisniewski

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/7fb3b05f2570

Comment 9

[Albert Scheiner [:alberts]]

Verified. Thanks!