Closed Bug 1683657 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 26964 - Determine the non-hangable run end when soft-hyphen is disabled

Categories

(Core :: Layout: Text and Fonts, task, P4)

task

Tracking

()

RESOLVED FIXED
86 Branch
Tracking Status
firefox86 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 26964 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/26964
Details from upstream follow.

b'Javier Fern\xc3\xa1ndez Garc\xc3\xada-Boente <jfernandez@igalia.com>' wrote:

Determine the non-hangable run end when soft-hyphen is disabled

Since r807457 we changed the TextBreakIterator default's behavior so
that it breaks always after a space, instead of before any space run.
In order to implement this new behavior, we needed to compute as well
the end of the non-hangable run of the Item being processed.

In the mentioned change, we forgot to apply this behavior in the code
path used when the soft-hypenation is not enabled. This CL fixes that
by determining the non-hangable run end in that case.

Bug: 1158747
Change-Id: I1a1324b3d775c24e44aa29b097c45e626d0ad76f

Reviewed-on: https://chromium-review.googlesource.com/2597581
WPT-Export-Revision: 7fd38e4f20d0168fbb28b8547a121538a5aa0ea3

Component: web-platform-tests → Layout: Text and Fonts
Product: Testing → Core

CI Results

Ran 14 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests

Status Summary

Firefox

PASS: 2

Chrome

FAIL: 2

Safari

PASS: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1c36c3285c0b [wpt PR 26964] - Determine the non-hangable run end when soft-hyphen is disabled, a=testonly
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 86 Branch
You need to log in before you can comment on or make changes to this bug.