Closed Bug 1683658 Opened 2 years ago Closed 2 years ago

Screen readers doesn’t read the print preview's “Pages per sheet” label

Categories

(Toolkit :: Printing, defect, P1)

defect

Tracking

()

VERIFIED FIXED
86 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox84 --- unaffected
firefox85 + verified
firefox86 + verified

People

(Reporter: emilghitta, Assigned: sfoster)

References

(Blocks 1 open bug)

Details

(Keywords: access, Whiteboard: [print2020_v85][old-ui-] [access-s3])

Attachments

(1 file)

Affected versions

  • Firefox 86.0a1 (BuildId:20201218095607)
  • Firefox 85.0b4 (BuildId:20201220193140)

Affected platforms

  • Windows 10 64bit (NVDA version 2020.3)
  • macOS 10.14 (VoiceOVer)

Steps to reproduce

  1. Launch Firefox.
  2. Open a random webpage
  3. Hit CTRL + P in order to open the print preview.
  4. Tab through the available print preview options until you reach the “Pages per Sheet”

Expected result

  • NVDA reads “Pages per sheet combo box 1 collapsed”

Actual result

  • NVDA reads “combo box 1 collapsed”

Regression Range

  • I don’t think that this is a regression.

Notes

  • [Suggested Severity] I think that S3 fits for this issue.

VoiceOver (macOS) is also affected.

OS: Windows → All
Summary: NVDA screen reader doesn’t read the print preview's “Pages per sheet” label → Screen readers doesn’t read the print preview's “Pages per sheet” label
Severity: -- → S3
Severity: S3 → --
Component: Disability Access APIs → Printing
Keywords: access
Product: Core → Toolkit
Whiteboard: [print2020_v85][old-ui-] → [print2020_v85][old-ui-] [access-s3]

pages-per-sheet-label should be associated with pages-per-sheet-picker.

[Tracking Requested - why for this release]: This feature will not be fully accessible to screen reader users without this fixed. I'm not sure if this is going to be enabled on 85 or not, so requesting tracking to be safe. If the pref is going to be disabled, we can live without this fix in 85.

Which feature/pref?

Flags: needinfo?(jteh)

I believe that James refers to print.tab_modal.enabled. Please note that there is a controlled rollout planed for 85.

This is a simple fix, we should try and get it into 85 if possible. I'll get a patch on here.

Assignee: nobody → sfoster
Severity: -- → S3
Priority: -- → P1
Status: NEW → ASSIGNED

(In reply to Emil Ghitta, QA [:emilghitta] from comment #5)

I believe that James refers to print.tab_modal.enabled.

Yes, and also print.pages_per_sheet.enabled; both of these have to be enabled in order for this bug to be relevant. Sorry for the lack of clarity; I wasn't quite clear as to what prefs were relevant here.

Flags: needinfo?(jteh)

As far as I know, the plan as it stands is to ship 85 with both print.tab_modal.enabled and print.pages_per_sheet.enabled toggled on, so I've flagged this as P1, albeit with relatively low severity. We can downgrade if necessary - I certainly wouldn't block shipping on it - but its a trivial change that we can uplift to fix an issue for our screenreader users.

(In reply to Sam Foster [:sfoster] (he/him) from comment #9)

We can downgrade if necessary - I certainly wouldn't block shipping on it

Respectfully, while it seems trivial, a screen reader user has no idea what this control does without a label. An advanced user might be able to figure it out. Many users will not without sighted assistance. It's bordering on an access-s2, but the feature is technically accessible, albeit undiscoverable, plus it's behind "More settings", so I wasn't quite willing to push it to access-s2.

The equivalent bug for a sighted user would be not having a label at all.

(In reply to James Teh [:Jamie] from comment #10)

Respectfully, while it seems trivial,

Sorry, I meant the patch was trivial, not the bug. Agreed this is confusing at best, possibly confounding. I'll flag the patch for uplift tomorrow and we'll take it from there.

Pushed by sfoster@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/468b5dfeed8f
Associate the pages-per-sheet label with the select/picker. r=mstriemer

Comment on attachment 9196480 [details]
Bug 1683658 - Associate the pages-per-sheet label with the select/picker. r?mstriemer

Beta/Release Uplift Approval Request

  • User impact if declined: Screenreader users will find it difficult to find and use the pages-per-sheet controls in the new print UI
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): The patch simply adds a missing attribute to associate the existing label with the form field.
  • String changes made/needed: None
Attachment #9196480 - Flags: approval-mozilla-beta?
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 86 Branch

Comment on attachment 9196480 [details]
Bug 1683658 - Associate the pages-per-sheet label with the select/picker. r?mstriemer

a11y fix, approved for 85.0b9

Attachment #9196480 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Flags: qe-verify+
QA Whiteboard: [qa-triaged]

This issue is verified fixed using Firefox 86.0a1 (BuildId:20210115035053) and Firefox 85.0b9 (BuildId:20210114193053) on Windows 10 64bit (NVDA), macOS 10.15 (VoiceOVer) and Ubuntu 20.04 (Orca Screen Reader).

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.