Closed Bug 1683713 Opened 3 years ago Closed 3 years ago

Ensure the restoring tab is not reused in addMultipleTabs

Categories

(Firefox :: Session Restore, defect)

Product:
Firefox
Component:
Session Restore
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
88 Branch
Tracking Flags:
Tracking Status
firefox88 --- fixed

People

(Reporter: tt, Assigned: tt)

References

Details

Attachments

(1 file)

Bug 1683713 - Ensure the restoring tab is not reused in addMultipleTabs;
48 bytes, text/x-phabricator-request
Details | Review

See https://bugzilla.mozilla.org/show_bug.cgi?id=1665942#c26.

It's possible that the selected tab is going to be reused but its tab state hasn't been reseted in SessionStore while restoring windows.

The issue was hidden in some cases because the userContextId attribute was undefined which causes bypassing the if-check.

Attachment #9194235 - Attachment description: Bug 1683713 - Ensure the tab state is removed from the linked browser when it's going to be reused in addMutipleTabs; → Bug 1683713 - Ensure the tab state is removed from the linked browser when it's going to be reused in addMultipleTabs;
Assignee: nobody → ttung
Status: NEW → ASSIGNED
Attachment #9194235 - Attachment description: Bug 1683713 - Ensure the tab state is removed from the linked browser when it's going to be reused in addMultipleTabs; → Bug 1683713 - Ensure the restoring tab is not reused in addMultipleTabs;
Summary: Ensure the tab state has been removed from its linked browser when deciding to reuse the selected tab in addMutilpleTabs → Ensure the restoring tab is not reused in addMultipleTabs
Pushed by ttung@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b04fe74185a0
Ensure the restoring tab is not reused in addMultipleTabs; r=dao

Backed out with Bug 1665942 for failures on browser_cookies_legacy.js

backout: https://hg.mozilla.org/integration/autoland/rev/2149651d7eb759e867b44d115298480399be1f1b

push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=d2f4a6c7e9ca100494c68870457a56c2da1187b4

failure log: https://treeherder.mozilla.org/logviewer?job_id=330222914&repo=autoland&lineNumber=24423

[task 2021-02-17T11:02:24.051Z] 11:02:24 INFO - TEST-PASS | browser/components/sessionstore/test/browser_cookies_legacy.js | cookie added by the cookie service -
[task 2021-02-17T11:02:24.051Z] 11:02:24 INFO - Buffered messages logged at 11:00:55
[task 2021-02-17T11:02:24.058Z] 11:02:24 INFO - Leaving test bound test_window
[task 2021-02-17T11:02:24.058Z] 11:02:24 INFO - Entering test bound test_browser
[task 2021-02-17T11:02:24.059Z] 11:02:24 INFO - waiting for cookie name58626=value58626 from http://example.com...
[task 2021-02-17T11:02:24.059Z] 11:02:24 INFO - TEST-PASS | browser/components/sessionstore/test/browser_cookies_legacy.js | cookie added by the cookie service -
[task 2021-02-17T11:02:24.060Z] 11:02:24 INFO - running
[task 2021-02-17T11:02:24.061Z] 11:02:24 INFO - Buffered messages finished
[task 2021-02-17T11:02:24.061Z] 11:02:24 INFO - TEST-UNEXPECTED-FAIL | browser/components/sessionstore/test/browser_cookies_legacy.js | Test timed out -
[task 2021-02-17T11:02:24.061Z] 11:02:24 INFO - GECKO(8918) | MEMORY STAT | vsize 3410MB | residentFast 416MB | heapAllocated 105MB
[task 2021-02-17T11:02:24.063Z] 11:02:24 INFO - TEST-OK | browser/components/sessionstore/test/browser_cookies_legacy.js | took 90044ms

Pushed by ttung@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d1ab61653c88
Ensure the restoring tab is not reused in addMultipleTabs; r=dao

https://hg.mozilla.org/mozilla-central/rev/d1ab61653c88

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox88: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: