1683784 - Extra `#` in error message for assigning to a private method

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect, P1)

Description

[Jason Orendorff [:jorendorff]]

It's illegal to assign to a private method. They're not properties.

But the error message is a bit off:

class C {
  #x() {}
  constructor() { this.#x = 1; }
}
new C;

TypeError: ##x is read-only

It should be #x, not ##x.

Comment 1

[Jonatan Klemets [:jon4t4n]]

I would like to work on this bug, and I have a patch ready. Who should I set as the reviewer?

Comment 2

[Matthew Gaudet (he/him) [:mgaudet]]

Jotan: You can assign to myself or :jorendorff!

Thanks for your interest in working on this, apologies for the delay in reply.

Comment 3

[Jonatan Klemets [:jon4t4n]]

Attachment: Bug 1683784 - Remove extra '#' in read-only error message for SymbolCode::PrivateNameSymbol. r=mgaudet

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c5fe59c15b01
Remove extra '#' in read-only error message for SymbolCode::PrivateNameSymbol. r=mgaudet

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/c5fe59c15b01